Skip to content

fix(security): patch Noema reader transitive vulnerabilities - #2629

Merged
seonghobae merged 2 commits into
mainfrom
fix/noema-reader-vulnerabilities-20261013
Oct 13, 2026
Merged

seonghobae merged 2 commits into
mainfrom
fix/noema-reader-vulnerabilities-20261013

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

The Noema document reader lock still contained two fixable vulnerabilities: HIGH CVE-2026-104850 in @modelcontextprotocol/sdk 1.30.0 and CRITICAL CVE-2026-90711 in proxy-addr 2.0.7. Pin SDK 1.31.0 and proxy-addr 2.0.8 as source overrides and regenerate the existing npm lock using Node 22.23.3 with scripts disabled. hwp-mcp 0.3.0 and @rhwp/core 0.7.7 stay pinned.

Validation: npm ci --ignore-scripts --omit=dev completed, npm ls resolved exactly one overridden SDK and proxy-addr, the reader modules imported on Node 22.23.3, focused Python checks passed 17 with 2 existing fixture skips, and refreshed-DB Trivy found zero fixable HIGH/CRITICAL findings in this exact tree. No security exceptions or gate changes.


Devin Review

Summary by CodeRabbit

  • 보안
    • 문서 리더의 종속성 버전을 보안 수정이 반영된 버전으로 고정했습니다.
    • 잠금 파일을 다시 생성해도 해당 버전이 유지되도록 설정했습니다.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 51fc9248-c095-4a4b-bca3-b13ac1607daa
📥 Commits

Reviewing files that changed from the base of the PR and between 376727e and ae4d929.

⛔ Files ignored due to path filters (1)
  • scripts/ci/noema-document-reader/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • scripts/ci/noema-document-reader/package.json
  • tests/test_noema_document_reader_dependency_security.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

문서 리더 패키지에 두 종속성의 버전 오버라이드를 추가했습니다. 보안 테스트는 잠금된 버전과 소스 오버라이드에 해당 버전 조건을 적용합니다.

Changes: 문서 리더 종속성

Layer / File(s) Summary
종속성 버전 고정 및 검증
scripts/ci/noema-document-reader/package.json, tests/test_noema_document_reader_dependency_security.py
패키지 오버라이드에 @modelcontextprotocol/sdk 1.31.0과 proxy-addr 2.0.8을 추가했습니다. 테스트는 잠금된 버전이 각 기준 이상인지, 소스 오버라이드가 지정된 버전인지 확인합니다.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~7 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 3d4b4

Merge Risk: ⚪ Minimal · up to 3d4b4

The reader’s production dependency lock matches the security overrides, with no identified change-specific merge blocker.

Pre-merge checks · Passed 5
Passed Passed checks (5 passed)
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed 제목은 Noema 리더의 전이 의존성 보안 취약점 수정이라는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae
seonghobae merged commit e249236 into main Oct 13, 2026
17 of 23 checks passed
@seonghobae
seonghobae deleted the fix/noema-reader-vulnerabilities-20261013 branch October 13, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant