Fix punctuation and paste in remote browser control - #422
Merged
davidmckayv merged 4 commits intoSep 8, 2026
Conversation
maximus792
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 7, 2026 14:15
davidmckayv
approved these changes
Sep 8, 2026
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Deep-reviewed against live code (correctness, governance, no vendor/secret/scale issues). Composed build+tests green. CHANGELOG/format rebase on CI-validated substance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.reaches CDP correctlyRoot cause
The computer service derived
windowsVirtualKeyCodefrom the first character ofevent.key. For., that produced 46, which Windows/CDP interprets as Delete; the correct browser key code is 190. The live screen also prevented every keydown, so Ctrl/Cmd+V could never produce a local paste event.Verification
bun test app/testsbun run --cwd app typecheckcd agent-computer && bun test && bun run typecheckbun run format:checkbun run lintgit diff --checkFixes #424.