feat(ddi)!: empty groups, end_group cells, appearance case, every setting (#160) - #165
Merged
Merged
Conversation
…ting (#160) - A group with nothing the codebook has is a section varGrp without members, placed by cdl:position. - An end_group row's cells (name, $kuid) are cdl:end_column notes on the group's varGrp. - cdl:appearance holds the cell as authored (Multiline); the model and readers use it lowercased. - A setting per language ({ lang: text }) is one cdl:setting per `<key>::<lang>`; a boolean setting is carried as its text. What stays lost: unregistered types (calculate) by design, and cell spellings (type-cell whitespace, `begin group`, a boolean setting as text). BREAKING CHANGE: cdl:appearance is no longer lowercased. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes the last #160 losses that aren't just spelling.
varGrpwith no members, placed bycdl:positionend_grouprow's cells (name,$kuid)cdl:end_columnon the group'svarGrpappearance(Multiline)cdl:appearanceas authored; the model and readers lowercase itcdl:settingper<key>::<lang>; a boolean as its textWhat stays lost, per
ddi2xlsform/README.md:calculate), by designbegin groupwritten with a space, a boolean setting coming back as textTests
end_group$kuidand capitalized appearances. All 5 properties pass at 5000 runs locally.npm run validateand the drift check passBreaking
cdl:appearanceis no longer lowercased.🤖 Generated with Claude Code