Skip to content

new tool: gui/export-world-map - #1606

Merged
ab9rf merged 3 commits into
DFHack:masterfrom
chdoc:gui-export-world-map
Sep 15, 2026
Merged

ab9rf merged 3 commits into
DFHack:masterfrom
chdoc:gui-export-world-map

Conversation

@chdoc

@chdoc chdoc commented Aug 15, 2026

Copy link
Copy Markdown
Member

Depends on DFHack/dfhack#5376 to be merged first.

@chdoc
chdoc force-pushed the gui-export-world-map branch from 1ecec90 to 8e88b02 Compare August 15, 2026 12:36
@chdoc

chdoc commented Aug 15, 2026

Copy link
Copy Markdown
Member Author
gui-export-world-map

@ab9rf
ab9rf requested a review from SilasD September 1, 2026 20:07
@chdoc
chdoc force-pushed the gui-export-world-map branch from 58f77d0 to 109cc47 Compare September 2, 2026 18:25

@SilasD SilasD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No red flags in the GUI script. Some quibbles and some questions, but nothing to hold up accepting the PR.

I'll do the other scripts later, I have to go grocery shopping.

Comment thread gui/export-world-map.lua
Comment thread gui/export-world-map.lua
Comment thread gui/export-world-map.lua Outdated
Comment thread gui/export-world-map.lua
Comment thread gui/export-world-map.lua
Comment thread gui/export-world-map.lua Outdated
Comment thread gui/export-world-map.lua Outdated
Comment thread gui/export-world-map.lua Outdated
Comment thread docs/gui/export-world-map.rst

@SilasD SilasD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no red flags, it all looks reasonable. another question and a quibble or two.

Comment thread internal/export-world-map/export-layers.lua
Comment thread internal/export-world-map/export-layers.lua
Comment thread internal/export-world-map/export-pops.lua Outdated
Comment thread internal/export-world-map/export-pops.lua
@SilasD

SilasD commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

looks great.

@ab9rf
ab9rf merged commit 0d0b2f5 into DFHack:master Sep 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants