You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Okay so I based my PR on the changes made by Robin at #8233, which seem to be based on this one, so in turn I've already used these changes. In general, my PR is quite similar to this one, with getPilots implemented and a couple of other minor changes.
In addition, this PR seems to have the same problem as mine about obtaining the jobs of a pilot. selectPilots calls self.getJobsForPilotByStamp(pilotStamp) but this function is not implemented. I guess this was the skeleton for a later implementation that never came. Maybe for the same reason?
Just one question, is adding the pilotStamp to the DB, Agent and Service required for the simplification part of the migration? Shouldn't we maintain the current functionality and try to adpat to DiracX?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
Thank you for writing the text to appear in the release notes. It will show up
exactly as it appears between the two bold lines
Please follow the template:
*Subsystem
NEW/CHANGE/FIX: explanation
For examples look into release.notes
ENDRELEASENOTES