Repository navigation
feat: payload graceful stop - #8814
Merged
Merged
Conversation
aldbr
requested review from
andresailer,
atsareg and
fstagni
as code owners
September 30, 2026 08:27
aldbr
marked this pull request as draft
September 30, 2026 09:00
…budget runs out A payload stopped when its budget runs out is killed, losing whatever it had produced but not yet written, and the job fails. The Watchdog still parsed StopSigRegex and StopSigNumber, but no longer acted on them. It now sends StopSigNumber to the processes of this job matching StopSigRegex once the budget left is below StopSigFinishWork, and not before the payload has done StopSigStartWork. It signals only descendants of the JobWrapper, never the JobWrapper itself, and does not escalate: the hard stop stays as the backstop. The options can now also be set in /Systems/WorkloadManagement/JobWrapper, which reaches jobs already submitted; the JDL still takes precedence. StopSigStartSeconds and StopSigFinishSeconds become StopSigStartWork and StopSigFinishWork, in CPU work, so that one figure means the same on fast and slow nodes. A payload that stops on the signal it was sent exits 128 + N. The JobWrapper now reports that as a success rather than an application error, unless the Watchdog then had to kill it anyway. Also adds an "Allocated time management" page to the Administrator Guide. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…pper ConfigTemplate Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
aldbr
force-pushed
the
wms-graceful-stop
branch
from
October 5, 2026 15:08
d2f023e to
313cda7
Compare
aldbr
marked this pull request as ready for review
October 5, 2026 15:16
fstagni
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #8746 (stacked on it: review the last commit only).
A payload stopped when its budget runs out is killed: whatever it had produced but not yet written is lost, and the job fails. The Watchdog still parsed
StopSigRegex/StopSigNumberbut no longer acted on them.StopSigFinishWork, and the payload has done at leastStopSigStartWork, the Watchdog sendsStopSigNumberto the processes of this job matchingStopSigRegex. It signals descendants of the JobWrapper only, never the JobWrapper itself, and does not escalate. The hard stop at the end of the budget stays as the backstop./Systems/WorkloadManagement/JobWrapper, which reaches jobs already submitted. The JDL still takes precedence.StopSigStartSeconds/StopSigFinishSecondsbecomeStopSigStartWork/StopSigFinishWork, in CPU work, so one figure means the same on fast and slow nodes.128 + N. The JobWrapper reports that as a success rather than an application error, unless the Watchdog then had to kill it anyway.Tested with a real application that supports it (Gauss, a Gaudi simulation) launched as in production, including inside apptainer for its older slc6 and centos7 stacks. With
StopSigNumber = 10it finishes the event in progress, finalizes and exits 0 with a complete output file andsuccess=Truein its XML summary. The documented regex matches only the application process, not the launchers above it, nor other applications that would be terminated by the signal.Part of #8745.
BEGINRELEASENOTES
*WorkloadManagement
NEW: the Watchdog can again ask a payload to wind down before its budget runs out (StopSigRegex, StopSigNumber, StopSigStartWork, StopSigFinishWork), configurable in /Systems/WorkloadManagement/JobWrapper as well as per job in the JDL
CHANGE: StopSigStartSeconds and StopSigFinishSeconds are replaced by StopSigStartWork and StopSigFinishWork, expressed in CPU work
FIX: a payload that stops on the signal the Watchdog sent it (exit code 128 + N) is not reported as an application error
NEW: "Allocated time management" page in the Administrator Guide
ENDRELEASENOTES