Skip to content

Merge order for the Water Data v1 PRs (#422–#425) #426

Description

@thodson-usgs

This issue tracks the four open PRs from 2026-09-22 that move the Water Data OGC getters to v1 and act on what that migration found. They must merge in the order below: #424 and #425 are stacked on the PRs before them, and #422 and #423 conflict in NEWS.md.

Merge order

  1. feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422: request v1 of the Water Data API, pinnable through api_version. Closes v1 of the water data apis has been released #421.
  2. fix(waterdata): accept the continuous method_category queryable #423: accept the continuous method_category queryable.
  3. test(waterdata): assert documented columns match the collection schema #424: live test that each getter's documented columns match the collection's /schema.
  4. feat(waterdata): name every column the OGC collections return #425: named parameters for 20 returned columns.
Order PR Branch Head (2026-09-29) Commits on the branch
1 #422 feat/waterdata-api-v1 a4bbcf25 #422
2 #423 fix/continuous-method-category 1460ecd0 #423, based directly on main
3 #424 test/documented-properties-monitor e181c46d #422 (a4bbcf25), #423 rebased onto #422 (08136c88), #424 (e181c46d)
4 #425 feat/expose-returned-columns 2aa8648b the three above, then #425 (2aa8648b)

All four branch from main at 75e56ab6, are drafts, and pass every CI check on their current heads.

Why this order

After each merge

main is squash-merged, so a merged PR's commit never becomes an ancestor of main. The later branches keep showing its changes until they are rebased. After each merge, rebase the next branch onto main, cutting at the stack commit that corresponds to the PR that just merged:

git fetch upstream && git fetch origin

# After #422 merges: replace #423 with its copy from the stack,
# which already has the NEWS.md conflict resolved.
git switch -C fix/continuous-method-category 08136c88
git rebase --onto upstream/main a4bbcf25
git push --force-with-lease origin fix/continuous-method-category

# After #423 merges:
git switch -C test/documented-properties-monitor origin/test/documented-properties-monitor
git rebase --onto upstream/main 08136c88
git push --force-with-lease origin test/documented-properties-monitor

# After #424 merges:
git switch -C feat/expose-returned-columns origin/feat/expose-returned-columns
git rebase --onto upstream/main e181c46d
git push --force-with-lease origin feat/expose-returned-columns

Checked locally (2026-09-29): after a squash merge of #422 onto 75e56ab6, #423's stack copy rebases cleanly; after a squash merge of that, #424 and #425 rebase with no conflicts.

The SHAs above are commits in the current #424 and #425 branches. They stay valid if a PR is only rebased before it merges. If a PR's content changes first (for example, after review), rebuild the branches above it before continuing.

Before each merge

Open items on individual PRs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions