You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue tracks the four open PRs from 2026-09-22 that move the Water Data OGC getters to v1 and act on what that migration found. They must merge in the order below: #424 and #425 are stacked on the PRs before them, and #422 and #423 conflict in NEWS.md.
main is squash-merged, so a merged PR's commit never becomes an ancestor of main. The later branches keep showing its changes until they are rebased. After each merge, rebase the next branch onto main, cutting at the stack commit that corresponds to the PR that just merged:
git fetch upstream && git fetch origin
# After #422 merges: replace #423 with its copy from the stack,# which already has the NEWS.md conflict resolved.
git switch -C fix/continuous-method-category 08136c88
git rebase --onto upstream/main a4bbcf25
git push --force-with-lease origin fix/continuous-method-category
# After #423 merges:
git switch -C test/documented-properties-monitor origin/test/documented-properties-monitor
git rebase --onto upstream/main 08136c88
git push --force-with-lease origin test/documented-properties-monitor
# After #424 merges:
git switch -C feat/expose-returned-columns origin/feat/expose-returned-columns
git rebase --onto upstream/main e181c46d
git push --force-with-lease origin feat/expose-returned-columns
Checked locally (2026-09-29): after a squash merge of #422 onto 75e56ab6, #423's stack copy rebases cleanly; after a squash merge of that, #424 and #425 rebase with no conflicts.
The SHAs above are commits in the current #424 and #425 branches. They stay valid if a PR is only rebased before it merges. If a PR's content changes first (for example, after review), rebuild the branches above it before continuing.
Before each merge
Mark the PR ready for review. main requires one approving review.
This issue tracks the four open PRs from 2026-09-22 that move the Water Data OGC getters to v1 and act on what that migration found. They must merge in the order below: #424 and #425 are stacked on the PRs before them, and #422 and #423 conflict in
NEWS.md.Merge order
api_version. Closes v1 of the water data apis has been released #421.continuousmethod_categoryqueryable./schema.feat/waterdata-api-v1a4bbcf25fix/continuous-method-category1460ecd0maintest/documented-properties-monitore181c46da4bbcf25), #423 rebased onto #422 (08136c88), #424 (e181c46d)feat/expose-returned-columns2aa8648b2aa8648b)All four branch from
mainat75e56ab6, are drafts, and pass every CI check on their current heads.Why this order
NEWS.md, where both add a top entry, so either could merge first on its own. But test(waterdata): assert documented columns match the collection schema #424 and feat(waterdata): name every column the OGC collections return #425 already include a copy of fix(waterdata): accept the continuous method_category queryable #423 rebased onto feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422 (08136c88) with that conflict resolved. Merging feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422 first reuses that resolution. Merging fix(waterdata): accept the continuous method_category queryable #423 first means resolving the conflict again in the other direction and rebuilding test(waterdata): assert documented columns match the collection schema #424 and feat(waterdata): name every column the OGC collections return #425. This order does not delay the fix for the failing nightly live run (35698389879): feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422 moves the queryables snapshot to v1, the v1 snapshot already listsmethod_category, and the monitor passes after feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422 alone./schema. It fails unlessdata_gap_interval(documented in feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422) andmethod_category(documented in fix(waterdata): accept the continuous method_category queryable #423) are both present.After each merge
mainis squash-merged, so a merged PR's commit never becomes an ancestor ofmain. The later branches keep showing its changes until they are rebased. After each merge, rebase the next branch ontomain, cutting at the stack commit that corresponds to the PR that just merged:Checked locally (2026-09-29): after a squash merge of #422 onto
75e56ab6, #423's stack copy rebases cleanly; after a squash merge of that, #424 and #425 rebase with no conflicts.The SHAs above are commits in the current #424 and #425 branches. They stay valid if a PR is only rebased before it merges. If a PR's content changes first (for example, after review), rebuild the branches above it before continuing.
Before each merge
mainrequires one approving review.NEWS.mddate to the day it merges (feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422, fix(waterdata): accept the continuous method_category queryable #423 and feat(waterdata): name every column the OGC collections return #425 all say 09/22/2026). The next rebase will then hit a one-lineNEWS.mdconflict; keep both entries, newest on top.type-checkruns over the PR merged intomain.Open items on individual PRs
2027-06-01, the configuration file acceptingapi_version, routing the dropped queryables to v0 rather than translating them forward, and the NEWS date.waterdata/endpoints.pyrequests. On itsmain-based branch theogcapicase fails live, becausemainrequests v0; it passes once feat(waterdata): request v1 of the Water Data API, pinnable through api_version #422 merges.