Repository navigation
Conversation
… needed for cross-compilation
illwieckz
changed the title
illwieckz
changed the title
slipher
left a comment
slipher
left a comment
There was a problem hiding this comment.
LGTM to:
external_deps: make possible to loop the cmake buildexternal_deps: deduplicate nacl from pnacl copy code
Apparently we already had ostensible support for configuring the platform more than once (the PLATFORM_LIST thing), but I guess there must have been some gaps. Anyway the platform reconfiguration/native package series looks pretty good, just some nits.
| BUILD_DIR="${WORK_DIR}/${BUILD_BASEDIR}" | ||
| PREFIX="${BUILD_DIR}/prefix" | ||
| PATH="${PREFIX}/bin:${PATH}" | ||
| PLATFORM_SYSTEM="$(echo "${PLATFORM}" | cut -f1 -d-)" |
| common_setup_native() { | ||
| case "$(uname -s)" in | ||
| CYGWIN_NT-*|MSYS_NT-*|MINGW*_NT-*) | ||
| EXE_EXT='.exe' |
There was a problem hiding this comment.
We already removed any attempts at MSYS support so this seems out of place.
| setup_platform() { | ||
| case "${1}" in | ||
| native) | ||
| export PLATFORM='native-native-native' |
There was a problem hiding this comment.
I don't think you want to export this
| } | ||
|
|
||
| # Set up environment for native host tools | ||
| setup_native() { |
There was a problem hiding this comment.
How about putting PLATFORM=native-native-native here? Then you can remove the whole setup_platform function.
| fi | ||
| } | ||
|
|
||
| dedupe_dir () |
There was a problem hiding this comment.
What's an example of duplicates that we have?
There was a problem hiding this comment.
I was going to say that the Saigo SDK has plenty of them, but we may move it out of the deps archive:
😁️
There was a problem hiding this comment.
But yes, I ported this deduplication code from the Saigo release script because this is preparatory work for the Saigo integration and then this script was meant to repackage the Saigo SDK, requiring then the same packaging optimizations.
I will have a look at it to see if it would still help once Saigo is removed from the picture.
2 participants
Merging more stuff from:
First rounds were:
This doesn't bump the deps version.
jdupesorrdfind. We can settle onjdupesif that's preferred. If none of those tools are present files are stored as normal files. Symlink dereference is still done but now done before the hardlink creation.linux-amd64andlinux-armhfwhen building deps forlinux-arm64(not implemented in that PR). This may also make possible to build the same software as a native tool and to rebuild it for the target if needed.nativeplatform and building native tools in a special prefix that doesn't contribute to the target package.pkg-configandnasmas native tools.