You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running ./fetch-externals (required for make check) will now clone a newer version of googletest that is now required. Breakpad requires C++20 and I have faced some old references of googletest not supporting it.
I haven't checked if that exact old reference was broken, but I've checked that the new reference is working.
Right, after some research, the commit reference was 5ec7f0c4a113e2f18ac2c6cc7df51ad6afc24081 after the main merge in our tree. Maybe a merge mismatch. That 5ec7f0 is not suitable for sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
./fetch-externals(required formake check) will now clone a newer version ofgoogletestthat is now required. Breakpad requires C++20 and I have faced some old references ofgoogletestnot supporting it.I haven't checked if that exact old reference was broken, but I've checked that the new reference is working.
We may use https://github.com/DaemonEngine/googletest if preferred.
Picked from: