Repository navigation
Conversation
… in STABS unit test The failure was observed on FreeBSD. Use POSIX-compatible regex syntax on POSIX systems while preserving compatibility with Windows' regex implementation.
…BS symbols The failure was observed on FreeBSD, but checking whether a name is mangled before demangling it is a platform-independent robustness improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically a continuation of:
But on the
make checkpartsrc/common/stabs_to_module_unittest: use POSIX regex on POSIX systems in STABS unit testThe failure was observed on FreeBSD. Use POSIX-compatible regex syntax on
POSIX systems while preserving compatibility with Windows' regex implementation.
src/common/stabs_to_module: check mangled names before demangling STABS symbolsThe failure was observed on FreeBSD, but checking whether a name is mangled
before demangling it is a platform-independent robustness improvement.
Actually a continuation and a reuse of: f591ce6
Picked from: