Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human acceptance is needed for the documented cohort limitation that leaves indirectly selected restricted datasets unblocked.
0 open findings
What changed in this PR
Adds Terra export restrictions for four oversized eMERGE GWAS datasets in the AnVIL explorer.
Changes:
- Disables Terra export options and shows explanatory warnings for affected datasets.
- Blocks cohort exports when affected datasets are explicitly selected, with hydration-aware rendering.
- Adds unit tests for restriction helpers, messages, and render conditions.
| File | Description |
|---|---|
| site-config/anvil-cmg/dev/export/export.ts | Adds conditional cohort export warnings and forms. |
| site-config/anvil-cmg/dev/detail/dataset/export/export.ts | Adds conditional dataset export warnings and forms. |
| app/viewModelBuilders/azul/anvil-cmg/common/viewModelBuilders.tsx | Implements restriction checks and warning builders. |
| app/viewModelBuilders/azul/anvil-cmg/common/constants.ts | Defines restricted datasets and explanation text. |
| tests/viewModelBuilders/export.test.ts | Tests cohort restrictions and messages. |
| tests/viewModelBuilders/dataset-export.test.ts | Tests dataset restrictions and rendering. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
|
Thanks Fran, this is nicely done. We can't ship it without the link to the Broad document that tells users how to get these datasets, so I'm marking it blocked until we have that URL. Once the link is in, this is ready to go. |
…datasets (#4953) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
frano-m
force-pushed
the
frano-m/4953-disable-anvil-terra-export
branch
from
October 15, 2026 23:49
1008b1e to
43c59fb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #4953.
Reviewers
@NoopDog.
Changes
TERRA_EXPORT_UNAVAILABLE_DATASET_TITLES(the four eMERGE GWAS datasets from azul#8134) and the explanation text inapp/viewModelBuilders/azul/anvil-cmg/common/constants.ts./datasets/{id}/export/export-to-terra) renders a warning instead of the export form./export/export-to-terra) renders a warning instead of the export form.Definition of Done (from ticket)
Disable the export to Terra functionality for the four datasets with an explanation as to why.
QA steps (optional)
Requires an account with access to the eMERGE GWAS datasets (they are managed access, so signed-out users only see the existing "request access" warning on their dataset export pages).
ANVIL_eMERGE_GWAS_GRU— "Export to Terra" is disabled with the explanation; navigating directly to its/export/export-to-terraroute shows the warning.ANVIL_eMERGE_GWAS_GRUin the "Dataset" filter and click Export — "Export to Terra" is disabled with the explanation;/export/export-to-terrashows the warning.Known Issues
@NoopDog — please confirm the cohort-export scope:
phs001584, or no filters at all) are not blocked and can still start a Terra export that fails.is/within/contains/intersects(no "is not", so we can't exclude the datasets from an export), and the file facets the explorer fetches are limited to the top 25 datasets, so they can't reliably tell us whether a broad selection contains them. The cleaner fix for that case would be Azul failing early (or supporting an exclusion operator), as the ticket mentions.🤖 Generated with Claude Code