Skip to content

Publish dd-openfeature in PR snapshots - #12400

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
leo.romanovsky/publish-openfeature-snapshot-artifacts
Sep 10, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
masterfrom
leo.romanovsky/publish-openfeature-snapshot-artifacts

Conversation

@leoromanovsky

@leoromanovsky leoromanovsky commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

The PR snapshot workflow publishes public, pipeline-specific and branch-specific artifacts for the agent and tracing APIs, but not the standalone OpenFeature provider. Consumers validating provider API changes such as #12387 therefore cannot download a matching immutable dd-openfeature.jar from the PR pipeline.

Changes

  • Build :products:feature-flagging:feature-flagging-api:jar in the existing upstream build job.
  • Retain the provider JAR for the S3 publication job.
  • Publish dd-openfeature.jar under both the branch-specific and pipeline-specific S3 keys.
  • Add the immutable provider URL to the Mosaic External Links sidebar.

Decisions

  • Extend the existing build and publication jobs rather than add a second pipeline path. This adds one small JAR artifact and upload, without duplicating checkout, dependency download, or polling work.
  • Use the stable public filename dd-openfeature.jar, matching the provider artifact name while hiding the changing snapshot version from consumers.
  • Keep this PR CI-only; it contains no runtime behavior change.

Validation

  • ./gradlew :products:feature-flagging:feature-flagging-api:jar -PskipTests -x spotlessCheck --no-daemon
  • git diff --check
  • End-to-end proof from Allow telemetry-free OpenFeature providers #12387 pipeline 135263337: dd-gitlab/publish-artifacts-to-s3 passed and both dd-java-agent.jar and dd-openfeature.jar are anonymously downloadable.
  • javap against that public provider JAR confirms Provider.Options.telemetryEnabled(boolean) and isTelemetryEnabled() are present. Its SHA-256 is 3ab84365b8b986cac53fcc0d610b5681e8fde44f65e2adbe095e4e89e5b2fa27.

Expose the OpenFeature provider beside the agent in the existing public S3 snapshot job.

Environment: Datadog workspace
@leoromanovsky
leoromanovsky marked this pull request as ready for review September 3, 2026 16:32
@leoromanovsky
leoromanovsky requested review from a team as code owners September 3, 2026 16:32
@leoromanovsky
leoromanovsky requested review from amarziali and erikayasuda and removed request for a team September 3, 2026 16:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-03T16:35:24.130712Z e573d9d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@leoromanovsky leoromanovsky added comp: openfeature OpenFeature type: feature Enhancements and improvements labels Sep 3, 2026

@datadog-prod-us1-4 datadog-prod-us1-4 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The workflow builds and retains the versioned OpenFeature provider JAR. It publishes the JAR to branch and pipeline S3 keys, and the external link uses the immutable pipeline key.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit e573d9d · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-prod-us1-4

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.00 s 14.01 s [-0.7%; +0.5%] (no difference)
startup:insecure-bank:tracing:Agent 12.94 s 13.00 s [-1.3%; +0.4%] (no difference)
startup:petclinic:appsec:Agent 17.65 s 17.49 s [+0.1%; +1.7%] (maybe worse)
startup:petclinic:iast:Agent 17.48 s 17.63 s [-1.8%; +0.0%] (no difference)
startup:petclinic:profiling:Agent 17.08 s 17.36 s [-2.7%; -0.5%] (maybe better)
startup:petclinic:sca:Agent 17.58 s 17.45 s [-0.2%; +1.6%] (no difference)
startup:petclinic:tracing:Agent 16.48 s 16.65 s [-2.0%; -0.0%] (maybe better)

Commit: 245793f8 · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@leoromanovsky
leoromanovsky added this pull request to the merge queue Sep 10, 2026
@dd-octo-sts

dd-octo-sts Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-10 00:41:22 UTC ℹ️ Start processing command /merge


2026-09-10 00:41:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-10 01:34:36 UTC ℹ️ MergeQueue: This merge request was merged

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 10, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit a4b447e into master Sep 10, 2026
602 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the leo.romanovsky/publish-openfeature-snapshot-artifacts branch September 10, 2026 01:34
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: openfeature OpenFeature type: feature Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants