Use configured repository proxy in embedded Maven tests - #12572
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CI Visibility Test Environment - sbt-scalatestJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
There was a problem hiding this comment.
More details
The proxy setting reaches each Maven test task. Each embedded Maven call uses the mirror file only when the proxy environment variable exists.
🤖 Datadog Autotest · Commit e2904f3 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
CI Visibility Test Environment - jolokiaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - nebula-release-pluginJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - heliboardJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - reactive-streams-jvmJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - netflix-zuulJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-kotlinJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - okhttpJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - sonar-javaJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - pass4sJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
CI Visibility Test Environment - spring_bootJob Status: 🟢 success
Baseline: median of Tests run to verify that CI Visibility behavior has not regressed in the current PR. |
|
/code blockers |
|
View all feedbacks in Devflow UI.
Checking merge blockers for #12572...
Detected 2 merge blocker(s) to address: 🟠 Pending
|
bric3
left a comment
There was a problem hiding this comment.
LGTM, but I'd like one tiny fix.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
1f1cbde
into
master
What Does This Do
Routes embedded Maven test builds and their dependency-prefetch step through the configured Maven repository proxy. Both test harnesses select a shared
mirrorOf=*settings file whenMAVEN_REPOSITORY_PROXYis present, and Gradle propagatesmavenRepositoryProxyto all test tasks in the module.Motivation
The embedded
MavenCliinstances do not inherit Gradle's repository configuration. They continued contacting Maven Central directly after the other repository paths were migrated, causing intermittent HTTP 429 failures before the test assertions could run.This extends the proxy-only approach from #12403, #12404, and #12491 to the Maven instrumentation tests, following the existing Maven smoke-test mirror configuration. Builds without a configured proxy retain their existing repository behavior.
Additional Notes
The failing Surefire 2.17 invocation reported:
Plugin resolution failed before the
MojoStartedcallback, leaving the helper'shandlerRanflag false. The same POM downloaded successfully about 4.5 seconds later in another invocation, confirming the transient external failure.Validation with the repository proxies configured,
CI=true, and Java 8:Contributor Checklist
Jira ticket: N/A