Skip to content

Use configured repository proxy in embedded Maven tests - #12572

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/maven-tests-depot
Sep 21, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits into
masterfrom
alexeyk/maven-tests-depot

Conversation

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor

What Does This Do

Routes embedded Maven test builds and their dependency-prefetch step through the configured Maven repository proxy. Both test harnesses select a shared mirrorOf=* settings file when MAVEN_REPOSITORY_PROXY is present, and Gradle propagates mavenRepositoryProxy to all test tasks in the module.

Motivation

The embedded MavenCli instances do not inherit Gradle's repository configuration. They continued contacting Maven Central directly after the other repository paths were migrated, causing intermittent HTTP 429 failures before the test assertions could run.

This extends the proxy-only approach from #12403, #12404, and #12491 to the Maven instrumentation tests, following the existing Maven smoke-test mirror configuration. Builds without a configured proxy retain their existing repository behavior.

Additional Notes

The failing Surefire 2.17 invocation reported:

HTTP/1.1 429 Too Many Requests
Your ip has exceeded rate limits.
Could not transfer artifact org.apache.maven.plugins:maven-surefire-plugin:pom:2.17
from/to central (https://repo.maven.apache.org/maven2): Too Many Requests (429)

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
    at datadog.trace.instrumentation.maven3.AbstractMavenTest.executeMaven(AbstractMavenTest.java:70)
    at datadog.trace.instrumentation.maven3.MavenUtilsTest.testGetMojoConfigValueReturnsConfiguredValue(MavenUtilsTest.java:106)

Plugin resolution failed before the MojoStarted callback, leaving the helper's handlerRan flag false. The same POM downloaded successfully about 4.5 seconds later in another invocation, confirming the transient external failure.

Validation with the repository proxies configured, CI=true, and Java 8:

./gradlew :dd-java-agent:instrumentation:maven:maven-3.2.1:test \
  :dd-java-agent:instrumentation:maven:maven-3.2.1:latestDepTest -PtestJvm=8
  • Default Maven suite: 48 passed, 32 skipped, 0 failures.
  • Latest Maven suite: 75 passed, 5 skipped, 0 failures.
  • Across both suites, Maven output recorded 651 download attempts through the configured proxy and zero direct Maven Central downloads.
  • Module formatting and final diff checks passed.

Contributor Checklist

  • Title follows the contribution guidelines.
  • Required type, component, AI-generated, and no-release-notes labels applied.
  • The new settings resource is covered by the existing Maven instrumentation CODEOWNERS rule.
  • No public configuration or documentation changes required.
  • Opened as a draft; use merge queue after approval.

Jira ticket: N/A

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM labels Sep 18, 2026
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Sep 18, 2026
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD marked this pull request as ready for review September 18, 2026 19:31
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from a team as code owners September 18, 2026 19:31
@AlexeyKuznetsov-DD
AlexeyKuznetsov-DD requested review from dougqh and jordan-wong and removed request for a team September 18, 2026 19:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-18T19:33:46.433568Z e2904f3 Draft marked ready
🔒 Security Review Completed 2026-09-18T19:34:47.484135Z e2904f3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - sbt-scalatest

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -26.79 55.43 $\color{green}{\blacktriangledown}$ -82.22 55.43 $\color{green}{\blacktriangledown}$ -82.22 66/216
agentEvpProxy -26.70 n/a n/a n/a n/a -

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@datadog-datadog-prod-us1-2 datadog-datadog-prod-us1-2 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The proxy setting reaches each Maven test task. Each embedded Maven call uses the mirror file only when the proxy environment variable exists.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Datadog Autotest · Commit e2904f3 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 59.10% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5014a72 | Docs | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.79 s 14.66 s [+0.0%; +1.7%] (maybe worse)
startup:insecure-bank:tracing:Agent 13.60 s 13.70 s [-1.3%; -0.0%] (maybe better)
startup:petclinic:appsec:Agent 17.03 s 16.87 s [+0.0%; +1.9%] (maybe worse)
startup:petclinic:iast:Agent 17.01 s 16.47 s [-1.1%; +7.6%] (no difference)
startup:petclinic:profiling:Agent 16.74 s 16.87 s [-1.9%; +0.3%] (no difference)
startup:petclinic:sca:Agent 16.94 s 16.76 s [-0.1%; +2.3%] (no difference)
startup:petclinic:tracing:Agent 16.19 s 15.72 s [-1.2%; +7.2%] (no difference)

Commit: 5014a72b · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - jolokia

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 94.65 93.23 $\color{red}{\blacktriangle}$ +1.42 93.23 $\color{red}{\blacktriangle}$ +1.42 34/122
agentless 90.72 89.58 $\color{red}{\blacktriangle}$ +1.14 89.58 $\color{red}{\blacktriangle}$ +1.14 34/120
agentlessCodeCoverage 99.06 99.00 $\color{red}{\blacktriangle}$ +0.06 99.00 $\color{red}{\blacktriangle}$ +0.06 35/120
agentlessLineCoverage 100.07 101.00 $\color{green}{\blacktriangledown}$ -0.93 101.00 $\color{green}{\blacktriangledown}$ -0.93 36/126

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - nebula-release-plugin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 37.01 36.42 $\color{red}{\blacktriangle}$ +0.59 36.42 $\color{red}{\blacktriangle}$ +0.59 35/118
agentless 36.40 35.70 $\color{red}{\blacktriangle}$ +0.70 35.70 $\color{red}{\blacktriangle}$ +0.70 35/118
agentlessCodeCoverage 43.33 44.48 $\color{green}{\blacktriangledown}$ -1.15 44.48 $\color{green}{\blacktriangledown}$ -1.15 35/118
agentlessLineCoverage 62.29 56.55 $\color{red}{\blacktriangle}$ +5.74 55.43 $\color{red}{\blacktriangle}$ +6.86 34/118

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - heliboard

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 11.70 9.92 $\color{red}{\blacktriangle}$ +1.78 10.13 $\color{red}{\blacktriangle}$ +1.57 32/109

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - reactive-streams-jvm

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 22.97 21.65 $\color{red}{\blacktriangle}$ +1.32 21.65 $\color{red}{\blacktriangle}$ +1.32 32/123
agentless 19.76 18.82 $\color{red}{\blacktriangle}$ +0.94 18.82 $\color{red}{\blacktriangle}$ +0.94 31/115
agentlessCodeCoverage 20.98 19.99 $\color{red}{\blacktriangle}$ +0.99 19.99 $\color{red}{\blacktriangle}$ +0.99 31/114
agentlessLineCoverage 27.36 26.45 $\color{red}{\blacktriangle}$ +0.91 26.98 $\color{red}{\blacktriangle}$ +0.38 15/57

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - netflix-zuul

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 40.78 87.80 $\color{green}{\blacktriangledown}$ -47.02 87.80 $\color{green}{\blacktriangledown}$ -47.02 37/116
agentless 34.04 81.05 $\color{green}{\blacktriangledown}$ -47.01 81.05 $\color{green}{\blacktriangledown}$ -47.01 34/112
agentlessCodeCoverage 45.94 97.04 $\color{green}{\blacktriangledown}$ -51.10 95.12 $\color{green}{\blacktriangledown}$ -49.18 34/112
agentlessLineCoverage 58.40 111.62 $\color{green}{\blacktriangledown}$ -53.22 111.62 $\color{green}{\blacktriangledown}$ -53.22 35/117

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-kotlin

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -41.71 12.87 $\color{green}{\blacktriangledown}$ -54.58 12.87 $\color{green}{\blacktriangledown}$ -54.58 34/120
agentless -41.89 11.88 $\color{green}{\blacktriangledown}$ -53.77 11.88 $\color{green}{\blacktriangledown}$ -53.77 32/111
agentlessCodeCoverage -39.76 15.41 $\color{green}{\blacktriangledown}$ -55.17 15.11 $\color{green}{\blacktriangledown}$ -54.87 32/111
agentlessLineCoverage -38.81 17.03 $\color{green}{\blacktriangledown}$ -55.84 17.38 $\color{green}{\blacktriangledown}$ -56.19 32/112

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - okhttp

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 21.79 19.99 $\color{red}{\blacktriangle}$ +1.80 19.99 $\color{red}{\blacktriangle}$ +1.80 35/109
agentless 20.47 19.20 $\color{red}{\blacktriangle}$ +1.27 19.59 $\color{red}{\blacktriangle}$ +0.88 31/106
agentlessCodeCoverage 22.71 22.99 $\color{green}{\blacktriangledown}$ -0.28 22.54 $\color{red}{\blacktriangle}$ +0.17 32/107
agentlessLineCoverage 40.47 38.67 $\color{red}{\blacktriangle}$ +1.80 38.67 $\color{red}{\blacktriangle}$ +1.80 31/108

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 18, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - sonar-java

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 2.95 19.20 $\color{green}{\blacktriangledown}$ -16.25 13.94 $\color{green}{\blacktriangledown}$ -10.99 33/122
agentless -5.55 11.65 $\color{green}{\blacktriangledown}$ -17.20 11.65 $\color{green}{\blacktriangledown}$ -17.20 31/120
agentlessCodeCoverage 60.76 77.88 $\color{green}{\blacktriangledown}$ -17.12 74.82 $\color{green}{\blacktriangledown}$ -14.06 31/120
agentlessLineCoverage 127.84 125.85 $\color{red}{\blacktriangle}$ +1.99 113.88 $\color{red}{\blacktriangle}$ +13.96 33/120

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 21, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - pass4s

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent -15.18 8.98 $\color{green}{\blacktriangledown}$ -24.16 9.92 $\color{green}{\blacktriangledown}$ -25.10 28/100
agentless -16.57 7.65 $\color{green}{\blacktriangledown}$ -24.22 9.35 $\color{green}{\blacktriangledown}$ -25.92 28/100
agentlessCodeCoverage -9.40 14.23 $\color{green}{\blacktriangledown}$ -23.63 15.72 $\color{green}{\blacktriangledown}$ -25.12 27/94

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@cit-pr-commenter-54b7da

cit-pr-commenter-54b7da Bot commented Sep 21, 2026

Copy link
Copy Markdown

CI Visibility Test Environment - spring_boot

Job Status: 🟢 success

Scenario This PR (%) 7d median Δ 7d 30d median Δ 30d runs (7d/30d)
agent 16.29 16.36 $\color{green}{\blacktriangledown}$ -0.07 16.36 $\color{green}{\blacktriangledown}$ -0.07 31/108
agentless 10.56 9.92 $\color{red}{\blacktriangle}$ +0.64 9.92 $\color{red}{\blacktriangle}$ +0.64 31/106
agentlessCodeCoverage 13.44 13.40 $\color{red}{\blacktriangle}$ +0.04 13.40 $\color{red}{\blacktriangle}$ +0.04 31/106
agentlessLineCoverage 22.36 22.09 $\color{red}{\blacktriangle}$ +0.27 22.09 $\color{red}{\blacktriangle}$ +0.27 33/108

Baseline: median of @test.tracer_overhead on main (gitlab) over the last 7/30 days, per OSS project & scenario. Δ = this PR − baseline median; red ▲ = more overhead, green ▽ = less overhead than baseline.

Tests run to verify that CI Visibility behavior has not regressed in the current PR.

@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/code blockers

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-21 12:51:13 UTC ℹ️ Start processing command /code blockers


2026-09-21 12:51:14 UTC ℹ️ Devflow:

Checking merge blockers for #12572...


2026-09-21 12:51:23 UTC ℹ️ Devflow: /code blockers

Detected 2 merge blocker(s) to address:

🟠 Pending

@bric3 bric3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like one tiny fix.

Comment thread dd-java-agent/instrumentation/maven/maven-3.2.1/build.gradle Outdated
@AlexeyKuznetsov-DD

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Sep 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-09-21 17:12:32 UTC ℹ️ Start processing command /merge


2026-09-21 17:12:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-09-21 18:25:21 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 1f1cbde into master Sep 21, 2026
602 of 604 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the alexeyk/maven-tests-depot branch September 21, 2026 18:25
@github-actions github-actions Bot added this to the 1.67.0 milestone Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: ci visibility Continuous Integration Visibility tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants