Repository navigation
Switch Kafka DSM demo consumers from Python to Java - #40110
Conversation
shaina-patel-23
changed the title
chnn
left a comment
chnn
left a comment
There was a problem hiding this comment.
One nit, looks good though!
There was a problem hiding this comment.
(nit) It seems a bit hacky to have a second unique cluster that shares the same cluster ID. All of the metrics reported from this cluster will be indistinguishable from metrics reported from the first cluster, which means the metrics queried in the UI will be some aggregate of the two.
I don't know if this will create problems, maybe it's fine? Alternatively, we could give the second cluster a unique ID and KAFKA_ADVERTISED_LISTENERS. Then (I think) the UI would show the one function cluster, and the offline partition warnings from the second cluster separately.
There was a problem hiding this comment.
Applied suggestion, ss is in the PR for the current state. We are now displaying two distinct cluster IDs so they're no longer indistinguishable.
- Original cluster: cluster:kafka-demo + kafka_cluster_id:Mka3OEVBNTcwNTJENDM2Qg
- Chaos cluster: cluster:kafka-demo-chaos + kafka_cluster_id:Y2hhb3NDbHVzdGVyMDAwMA
…d the choas cluster
* Displaying infra metrics and offline partition health card * switched consumer groups from py to java * added a second cluster to distinguish between the original cluster and the choas cluster
3 participants
What does this PR do? What is the motivation?
Motivation
Previously we weren't able to see the consumer group members and configuration details for python consumers. This PR fixes that.
Changes
cluster:kafka-demo-chaosin the UI instead of getting mashed together with the main cluster.Testing
Consumer member group
Distinguishable clusters
Merge readiness
AI assistance
For Datadog employees:
<name>/<description>convention and include the forward slash (/). If you've already created your PR with an incorrect branch name, please rename your branch and open a fresh PR./reviewto run an automated check that catches common issues before a Documentation team member reviews your PR.Additional notes