AGTMETRICS-599 split tags containing commas - #342
Merged
Merged
Conversation
With dogstatsd, it was possible to pass multiple tags as a single, comma-separated string. This happened to work by accident with dogstatsd because such tags are simply inserted into the on the-wire payload and later split into separate tags by the agent. Dogstatsd http preserves tags boundaries, so such strings are treated as a single tag, and then commas are stripped when the intake normalizes the tag. This patch adds tags splitting to avoid breaking clients relying on this behavior. Since scanning tags for commas adds overhead, we provide an opt-out.
vickenty
marked this pull request as ready for review
September 30, 2026 13:00
rayz
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With dogstatsd, it was possible to pass multiple tags as a single, comma-separated string. This happened to work by accident with dogstatsd because such tags are simply inserted into the on the-wire payload and later split into separate tags by the agent. Dogstatsd http preserves tags boundaries, so such strings are treated as a single tag, and then commas are stripped when the intake normalizes the tag.
This patch adds tags splitting to avoid breaking clients relying on this behavior. Since scanning tags for commas adds overhead, we provide an opt-out.