Repository navigation
Fix nil strategy assignment for non-default databases - #731
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README documents
strategy = nilas the way to select the no-op strategy. With a non-default database, that assignment instead raisesArgumentError:This also prevents
DatabaseCleaner.strategy = nilfrom disabling cleaning across a registry that includes named databases. The reproduction needs only database_cleaner-core; it does not open a database connection.Change
Pass the strategy accessor result to
set_strategy_db, so the existing nil-to-NullStrategy normalization runs before assigning the database. Keep the existing validation for custom strategies that do not support named databases.Add regression coverage for the individual cleaner and the mixed default/named-database registry, including no-op block execution.
Validation