Remove separate multi-cam display signal - #125
Open
C-Achard wants to merge 2 commits into
Open
Conversation
Simplify multi-camera frame delivery by removing the throttled `display_ready` path and relying on `frame_ready` for both processing and UI updates. The main window now marks display state dirty when `frame_ready` arrives, and the controller no longer maintains GUI FPS-based display emission logic.
C-Achard
added
bug
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
display_ready and its GUI-throttling state remain declared but unused/misleading after removing the emission path, and the frame_ready signal comment is now inaccurate.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR removes the separate throttled multi-camera display_ready signal path to avoid “double throttling” and instead uses frame_ready as the single source of truth for both processing and UI refresh triggering.
Changes:
- Removed the
_should_emit_display_ready()throttling helper and thedisplay_ready.emit(...)path fromMultiCameraController. - Updated
MainWindowto rely solely onframe_readyand mark the display as dirty from the processing-ready handler. - Tweaked the OpenCV text font used for tiled camera labels.
File summaries
| File | Description |
|---|---|
dlclivegui/utils/display.py |
Changes the OpenCV font used for camera label overlay in tiled frames. |
dlclivegui/services/multi_camera_controller.py |
Removes the throttled GUI-only display_ready emission path, relying on frame_ready only. |
dlclivegui/gui/main_window.py |
Stops connecting to display_ready and triggers display refresh via frame_ready updates. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
478
to
482
| if frame_data is not None: | ||
| with timing.measure("Multi.emit.frame_ready"): | ||
| self.frame_ready.emit(frame_data) | ||
|
|
||
| # GUI-only path: throttled display updates | ||
| if self._should_emit_display_ready(): | ||
| with timing.measure("Multi.emit.display_ready"): | ||
| self.display_ready.emit(frame_data) | ||
|
|
||
| timing.note_frame() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix double throttling of frame delivery by removing the extra throttled
display_readypath and relying onframe_readyfor both processing and UI updates.