Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Generated sample components reference nonexistent resources, and the routed Home component is incorrectly non-standalone.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates DevExtreme schematics for Angular 20 and its suffixless component filenames.
Changes:
- Upgrades Angular schematic dependencies to 20.3.37.
- Adapts view/layout generation and tests to new filenames.
- Adds updated Home, Profile, and Tasks sample views.
File summaries
| File | Description |
|---|---|
pnpm-lock.yaml |
Locks Angular 20 dependencies. |
packages/devextreme-schematics/package.json |
Upgrades Angular packages. |
packages/devextreme-schematics/src/add-view/index.ts |
Supports suffixless view files. |
packages/devextreme-schematics/src/add-view/index_spec.ts |
Updates view expectations. |
packages/devextreme-schematics/src/add-layout/index_spec.ts |
Updates layout expectations. |
packages/devextreme-schematics/src/add-app-template/index_spec.ts |
Updates template expectation. |
packages/devextreme-schematics/src/add-sample-views/files/pages/tasks/tasks.ts |
Adds Tasks component. |
packages/devextreme-schematics/src/add-sample-views/files/pages/tasks/tasks.html |
Adds Tasks grid. |
packages/devextreme-schematics/src/add-sample-views/files/pages/tasks/tasks.scss |
Adds Tasks styling. |
packages/devextreme-schematics/src/add-sample-views/files/pages/profile/profile.ts |
Adds Profile component. |
packages/devextreme-schematics/src/add-sample-views/files/pages/profile/profile.html |
Adds Profile markup. |
packages/devextreme-schematics/src/add-sample-views/files/pages/profile/profile.scss |
Adds Profile styling. |
packages/devextreme-schematics/src/add-sample-views/files/pages/home/home.ts |
Adds Home component. |
packages/devextreme-schematics/src/add-sample-views/files/pages/home/home.html |
Adds Home content. |
packages/devextreme-schematics/src/add-sample-views/files/pages/home/home.scss |
Adds Home styling. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
packages/devextreme-schematics/src/add-sample-views/files/pages/home/home.ts:6
- The generated files are
home.htmlandhome.scss, so the current URLs are unresolved. In addition, this component is routed directly and is not declared by any NgModule, so leaving it non-standalone makes the generated route invalid.
- Files reviewed: 7/16 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Module resolution can select components instead of modules, and template-generation rules remain inconsistent with Angular 20 filenames.
Get a fresh assessment by requesting another Copilot review.
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 9/16 changed files
- Comments generated: 2
- Review effort level: Balanced
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Sample routes still import removed .component paths, causing generated applications to fail module resolution.
Get a fresh assessment by requesting another Copilot review.
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
- Files reviewed: 9/16 changed files
- Comments generated: 1
- Review effort level: Balanced
| }, | ||
| { | ||
| glob: '{src/**/!(app.component).*,devextreme.json,e2e/**/*.*}', | ||
| glob: 'src/app/pages/**/*.*', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.