Add DAWN processing workflow template - #1602
Open
Oli-Jones475 wants to merge 1 commit into
Open
Conversation
Contributor
|
You got 2 failing checks. |
Oli-Jones475
force-pushed
the
DAWN-processing-template
branch
from
September 10, 2026 13:03
3421b02 to
f481136
Compare
Oli-Jones475
changed the title
hazdl
approved these changes
Sep 11, 2026
hazdl
left a comment
hazdl
left a comment
Contributor
There was a problem hiding this comment.
Please check the comments I added.
| command: [/bin/sh] | ||
| source: | | ||
| touch /tmp-dir/file-mount-path-from-config.txt | ||
| cat {{ workflow.parameters.confpath }} | sed -n 's|^ *"filePath": *"|| p' | sed 's/",*$//' > /tmp-dir/file-mount-path-from-config.txt |
Contributor
There was a problem hiding this comment.
Consider validating that the required JSON fields (filePath, processingPath, and outputFilePath) were successfully extracted before continuing. If any are missing or empty, the workflow may proceed with invalid mount paths and fail later with less obvious mount or pod startup errors. Failing early with a clear error message would make troubleshooting easier.
hazdl
self-requested a review
September 11, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.