Skip to content

test: add unit tests for AppiumLocatorConverter - #28

Closed
Dor-bl wants to merge 3 commits into
masterfrom
test-appium-locator-converter-15278513905858274636
Closed

Dor-bl wants to merge 3 commits into
masterfrom
test-appium-locator-converter-15278513905858274636

Conversation

@Dor-bl

@Dor-bl Dor-bl commented Oct 11, 2026

Copy link
Copy Markdown
Owner

Adds unit tests for AppiumLocatorConverter in test/unit/webdriver/locator_converter_test.py.
The new test suite covers:

  • Verification of inheritance from selenium.webdriver.remote.locator_converter.LocatorConverter.
  • Verification that standard and Appium-specific locator strategies (such as AppiumBy.ACCESSIBILITY_ID, AppiumBy.ANDROID_UIAUTOMATOR, AppiumBy.IOS_PREDICATE, AppiumBy.IOS_CLASS_CHAIN) and selectors are returned unmodified as a (by, value) tuple.
  • Coverage for edge case locator strategies and values.

PR created automatically by Jules for task 15278513905858274636 started by @Dor-bl

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Dor-bl commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

Closing as superseded by #31. That PR tests the locator passthrough at the driver level: it checks the using/value sent for By.ID/NAME/CLASS_NAME. Unlike these direct convert() tests, it also fails if the AppiumLocatorConverter wiring in webdriver.py is removed.


Generated by Claude Code

@Dor-bl Dor-bl closed this Oct 12, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #31. That PR tests the locator passthrough at the driver level: it checks the using/value sent for By.ID/NAME/CLASS_NAME. Unlike these direct convert() tests, it also fails if the AppiumLocatorConverter wiring in webdriver.py is removed.


Generated by Claude Code

Understood. Acknowledging that this work is superseded and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant