Repository navigation
Release trigger session on concurrency conflicts and cancellation - #220
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Concurrency cleanup occurs before the final interception outcome, breaking suppressed and re-entrant failure paths.
Review effort: Balanced
Findings: 1
What changed in this PR
Fixes trigger-session leaks after concurrency conflicts and canceled saves, especially for pooled contexts.
Changes:
- Handles concurrency and cancellation interceptor callbacks.
- Resets interceptor state between context-pool leases.
- Adds lifecycle and pooling regression tests.
| File | Description |
|---|---|
TriggerSessionSaveChangesInterceptorReleaseTests.cs |
Tests session release paths. |
ServiceCollectionExtensionsTests.cs |
Tests trigger-instance reuse across leases. |
TriggerSessionSaveChangesInterceptor.cs |
Adds failure, cancellation, and reset handling. |
TriggerInstanceFactory.cs |
Restores supplied trigger instances after reset. |
TriggersOptionExtension.cs |
Registers interceptor reset support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #219