-
Notifications
You must be signed in to change notification settings - Fork 2
Fix rimport called on a directory #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
918d9de
chore: git-ignore the .superpowers scratch directory
samsrabin ff40fca
tests(rimport): red tests for walk_files
samsrabin 8b1b94e
tests(rimport): red tests for expand_directories
samsrabin 5a50396
tests(rimport): red tests for empty-argument rejection
samsrabin 7fcc0d1
tests(rimport): red tests for main's provenance split and exit codes
samsrabin 65f9de6
tests(rimport): pin the named-vs-discovered count in the abort-everyt…
samsrabin 7405fce
tests(rimport): assert the relink half of staging, not just the copy
samsrabin f3e66a5
tests(rimport): red tests for directory and exit-code help text
samsrabin 3905824
tests(rimport): fix round 1 – strengthen discriminators in help-text …
samsrabin cdeea46
tests(rimport): red end-to-end tests for directory enumeration
samsrabin b80f41d
rimport: Add walk_files and the Entry/Skip types
samsrabin bc7679d
rimport: Add expand_directories with named-vs-discovered provenance
samsrabin 13e5854
rimport: Fix expand_directories count to report distinct files, not sum
samsrabin 3722d36
rimport: Reject empty filename arguments
samsrabin 1aa596b
rimport: Enumerate directory arguments instead of rejecting them
samsrabin 8a9e245
rimport: Document exit code 3 and annotate two locals in main
samsrabin 4685ca1
rimport: Document directory expansion and exit codes in --help
samsrabin 166e3fc
rimport: Use custom formatter to wrap description while preserving ep…
samsrabin 24d9eae
tests(rimport): red test for a named unreadable directory
samsrabin 4d3040c
tests(rimport): pin the pre-flight count for a named unreadable direc…
samsrabin bbfed34
rimport: Treat a named unreadable directory as a named failure
samsrabin 9798d27
tests(rimport): red tests for how walk skips are reported
samsrabin bf26267
rimport: Report walk skips, and only claim emptiness when true
samsrabin 3e1df18
tests(rimport): red tests for the skip-warning guard's real question
samsrabin 666daa9
rimport: Ask whether a skip was named, not whether it is the walk root
samsrabin 8bf484f
docs(rimport): Exit 3 also means a directory could not be read
samsrabin bc326e3
tests(rimport): red test for a path under an unreadable parent
samsrabin 6fe8f09
rimport: Do not crash probing a path under an unreadable parent
samsrabin 9c45f82
rimport: Correct a false claim about which Python versions crash
samsrabin 455ffa0
docs: Describe rimport directory enumeration in the README
samsrabin 0ce3e6f
docs: Match the README's em-dash voice
samsrabin f5e37a0
docs: Scope the all-or-nothing promise to named paths
samsrabin 5f1cb23
tests(rimport): red tests for skips that duplicate themselves
samsrabin 7b64004
rimport: Give Skip its provenance, and collapse duplicate skips
samsrabin 3bd5a06
rimport: Name exit 2's real triggers in --help, and state the precedence
samsrabin 5ea1a5e
tests(rimport): Pin directory expansion on --file and --list
samsrabin 4d41034
tests(rimport): red test for a named directory outside the root
samsrabin 402dbf3
rimport: Scope directory expansion to the inputdata tree
samsrabin c3c7a63
rimport: Pin the check order, and scope the enumeration promise
samsrabin 0d14917
docs: Say why a symlink to a directory is not enumerated
samsrabin 8df280e
rimport: Name the expansion flag for what it means, and drop a rename
samsrabin faa6a0c
rimport: Say "item(s)", and stop printing the path twice
samsrabin fff73d4
tests(rimport): State what each test pins, not how it got there
samsrabin 6523dc6
tests(rimport): Make three tests check what they claim to
samsrabin 2bcba2b
tests(rimport): Pair every exit-code test with its --check twin
samsrabin 9fa0db6
docs: Give exit codes their own README section
samsrabin d1d8992
Pin reason_text, and say "anything" where a directory can be skipped
samsrabin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| __pycache__ | ||
| .coverage | ||
| .vscode | ||
| .superpowers/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.