merge queue: checking #1206 on main (3e0b253) - #1208
Closed
mergify[bot] wants to merge 4 commits into
Closed
mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
A test that looked a flag up through os.environ read the settings of whoever ran it: with CATSTACK_UNVERIFIED_TAG_BEHAVIOR=do_not_emit in ~/.catstack.env, seven unverified-tag-ledger tests failed locally and passed in CI. Exported CATSTACK_* variables, the checkout's own .env, the real HOME (hook state under ~/.cache, git config) and the real codex install leaked the same way. run_all_tests.sh now sources scripts/test/hermetic_env.sh first. It unsets every inherited CATSTACK_, GIT_, CLAUDE_, CODEX_, CURSOR_ and XDG_ variable, points HOME and the global git config at a throwaway directory, and sets CATSTACK_SKIP_ENV_FILES so the flag reader never opens the real ~/.catstack.env or the checkout's .env. tests/test_hermetic_test_env.py starts that setup from a polluted environment and fails if anything gets through. Tests the stricter run exposed: JudgeTestCase now stubs the codex model catalog and config instead of running the real codex binary, the run_all_tests tests copy hermetic_env.sh into their fake repo, and the ledger tests set the skip list themselves so they are clean when run alone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Change-Id: Iafa1d66bc02d271ee4717d27f030ac4e075c7b6a
…test) Exit code: 0
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
#1206 is queued for merge on branch main (3e0b253).
This pull request has been created by Mergify to check the mergeability of #1206.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
admin-bypassfor merge:check-success = lintcheck-success = testcheck-success = validateRequired conditions to stay in the queue:
-draftbase=mainlabel=admin-bypass