Add spreadsheet completeness stop guard - #1221
Merged
Conversation
Change-Id: I913b91811835219351c9267075e078ccbe5795d1
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f6434a10-6b69-481a-9c13-8f5ebd9eddb6) |
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 46 minutes 11 seconds in the queue, including 45 minutes 49 seconds running CI. Required conditions to merge
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A stop check now blocks a claim that the sheet is done. The text must say that coverage passed. The check allows three tries. After that, the claim stays blocked and the missing names stay listed.
Review Claim
The stop check blocks a claim that the sheet is done unless the text includes the coverage receipt, and it allows at most three tries.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
A spreadsheet completion claim cannot pass without the exact coverage receipt; incomplete coverage remains blocked after the retry limit.
Slice Rationale
This pull request contains only the engine hook and harness manifests. Schema and derived-estimate validation stay on the product-skill pull request.
Non-goals
Test Plan
Test Plan
python3 -m unittest discover -s engine/hooks/spreadsheet-completeness-guard/tests -p test_*.pyRevert Plan
Revert Plan
git revert 2b204c70