reflect: catch an evidence-order correction from the ledger transition, not from wording by EdbertChan · Pull Request #782 · EdbertChan/catstack

EdbertChan · 2026-09-22T14:31:07Z

Summary

A correction can be about order, not error. Saying "I was right, but I said it before I checked" admits nothing was wrong, so no wording-based detector sees it.

Both detectors here require a wrongness word, so that shape was invisible.

The exact signal already exists: a claim going from open to resolved is the event "this was asserted before its check ran, and the check has now run."

That transition now triggers the review nudge.

Review Claim

A claim closing in the ledger triggers the review nudge, with no wording match involved.

Review Lane

behavior

Review Unit

engine-runtime

Safety Invariant

The trigger is a state change the ledger already records, so it cannot fire on a claim that was never opened, and it fires at most once per claim. No phrase list gates it.

Slice Rationale

Rebased onto main; the wrong-check-reflect commit this once sat on already landed as #796. Kept separate because it changes what fires the nudge, not how claims are tracked.

Non-goals

Does not widen the regex retraction scan; three tests pin its gap on purpose. Does not change the nudge's wording. The wrong-check-reflect judge dictionary does gain the two real sentences as match cases, and its meaning now names "right, but said before it was checked" as a match.

Test Plan

Run at this commit:

python3 -m unittest discover -s engine/hooks/unverified-tag-ledger/tests
Ran 37 tests in 6.534s
OK

python3 -m unittest discover -s engine/hooks/wrong-check-reflect/tests
Ran 36 tests in 84.462s
OK

Added cases pin the two real sentences from the session that motivated this, both of which the wording detectors stay silent on.

Revert Plan

Revert this commit. Corrections about order go undetected again, as they do on main.

EdbertChan · 2026-09-22T14:31:19Z

This pull request is part of a Mergify stack:

#	Pull Request	Link
1	wrong-check-reflect: one shot per reply, and scope the reflect scan to the turn	#796
2	reflect: catch an evidence-order correction from the ledger transition, not from wording	#782	👈
3	unverified-tag-ledger: gate the next-prompt reminder, default to stale only	#783
4	diu-stop: a file citation buys silence only when it is backed	#784
5	diu-stop: the marker gate reads prose, so a mention is not a use	#785
6	cat-mode: show the escape-hatch tag in the form the gate accepts	#786
7	principle-subagent-inherits-scope: a brief carries decisions, not just facts and a question	#788
8	llm-judge: claude is the only default runner	#793

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 97efd7e. Configure here.}

EdbertChan · 2026-09-22T18:38:35Z

Revision history

#	Type	Changes	Date
1	initial	`97efd7e`	2026-09-22 18:38 UTC
2	rebase	`97efd7e → 65902c9` (rebase only)	2026-09-22 18:38 UTC
3	rebase	`65902c9 → 21fb367` (rebase only)	2026-09-23 14:06 UTC

mergify · 2026-09-23T18:29:02Z

Queued — the merge queue status continues in this comment ↓.

EdbertChan · 2026-09-23T18:47:32Z

Mergify repair stopped: GitHub reports merge conflict. The retry cap was reached for current head 21fb367.

EdbertChan · 2026-09-23T20:37:50Z

@Mergifyio queue

mergify · 2026-09-23T20:38:17Z

Merge Queue Status

🛑 Queue command has been cancelled

…n, not from wording Both retraction detectors need a wrongness word. Two real corrections carry none, because the claim was true and only its order was wrong: "Correcting one claim and arming the check I implied:" "I was right - but I said it a turn before I checked it" Primary fix, no regex and no model: a ledger row going outstanding -> discharged IS the event "a claim was asserted before its check ran, and the check has now run". The Stop that discharges a row now reports it as a reflect trigger. It reads state, so the reply's wording is not consulted at all. Secondary fix: the judge dictionary's meaning now covers "right, but said before it was checked", and both real strings are eval cases. Run against the real judge, all six cases land where the dictionary says they should. The regex scan keeps its hole on purpose, pinned by three tests so the next author widens it knowingly rather than by accident. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Change-Id: I99190104b68d88f78aa9c8a706c9a6d23055aecc

cursor · 2026-09-24T03:33:17Z

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_649337ee-0879-45f7-861b-676c5a614429)

mergify · 2026-09-24T03:33:50Z

queue

🛑 The pull request has been removed from the queue `admin-bypass`

Details

The pull request #782 has been manually updated.

You can take a look at Mergify Merge Queue check runs for more details about the failure.

EdbertChan · 2026-09-24T04:04:26Z

@Mergifyio queue

mergify · 2026-09-24T04:04:37Z

Merge Queue Status

✅ Entered queue — 2026-09-24 04:04 UTC · Rule: admin-bypass · triggered by @EdbertChan with the @mergifyio queue command
✅ Checks passed · on draft merge queue: checking #782 on main (5b4a082), stacked on 4 pull requests ahead #904
✅ Merged — 2026-09-24 04:32 UTC · at ca2d6d631589df4e85b92d3f8487dc3ae28bfca6 · squash

This pull request spent 27 minutes 41 seconds in the queue, including 27 minutes 3 seconds running CI.

Required conditions to merge

check-success = lint
check-success = test
check-success = validate

This was referenced Sep 22, 2026

unverified-tag-ledger: gate the next-prompt reminder, default to stale only #783

Merged

unverified-tag-ledger: read the turn's tools from the transcript, not a key Claude Code never sends #780

Merged

cursor Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread engine/hooks/unverified-tag-ledger/detect.py

This was referenced Sep 22, 2026

wrong-check-reflect: only a real /reflect invocation counts as already asked #789

Closed

llm-judge: claude is the only default runner #793

Closed

EdbertChan changed the base branch from stack/EdbertChan/reflect/subagent-decisions-slot-20260922/wrong-check-reflect-one-shot-per-reply-scope--db90d55f to main September 22, 2026 18:38

EdbertChan force-pushed the stack/EdbertChan/reflect/subagent-decisions-slot-20260922/catch-evidence-order-correction-ledger-transition--99190104 branch from 97efd7e to 65902c9 Compare September 22, 2026 18:38

EdbertChan changed the base branch from main to stack/EdbertChan/reflect/subagent-decisions-slot-20260922/wrong-check-reflect-one-shot-per-reply-scope--60c5103d September 22, 2026 18:38

EdbertChan mentioned this pull request Sep 22, 2026

wrong-check-reflect: one shot per reply, and scope the reflect scan to the turn #796

Merged

EdbertChan added the admin-bypass label Sep 22, 2026

EdbertChan force-pushed the stack/EdbertChan/reflect/subagent-decisions-slot-20260922/wrong-check-reflect-one-shot-per-reply-scope--60c5103d branch from 9473d50 to ed08f60 Compare September 23, 2026 14:06

EdbertChan force-pushed the stack/EdbertChan/reflect/subagent-decisions-slot-20260922/catch-evidence-order-correction-ledger-transition--99190104 branch from 65902c9 to 21fb367 Compare September 23, 2026 14:06

EdbertChan changed the base branch from stack/EdbertChan/reflect/subagent-decisions-slot-20260922/wrong-check-reflect-one-shot-per-reply-scope--60c5103d to main September 23, 2026 18:27

EdbertChan force-pushed the stack/EdbertChan/reflect/subagent-decisions-slot-20260922/catch-evidence-order-correction-ledger-transition--99190104 branch from 21fb367 to 13ab621 Compare September 24, 2026 03:33

mergify Bot added the queued label Sep 24, 2026

mergify Bot mentioned this pull request Sep 24, 2026

merge queue: checking #782 on main (5b4a082), stacked on 4 pull requests ahead #904

Closed

6 tasks done

mergify Bot merged commit ca2d6d6 into main Sep 24, 2026
8 checks passed

mergify Bot removed the queued label Sep 24, 2026

Navigation Menu

reflect: catch an evidence-order correction from the ledger transition, not from wording - #782

reflect: catch an evidence-order correction from the ledger transition, not from wording#782
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/reflect/subagent-decisions-slot-20260922/catch-evidence-order-correction-ledger-transition--99190104

EdbertChan commented Sep 22, 2026 •

edited

Loading

Uh oh!

EdbertChan commented Sep 22, 2026 •

edited

Loading

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

EdbertChan commented Sep 22, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

EdbertChan commented Sep 23, 2026

Uh oh!

EdbertChan commented Sep 23, 2026

Uh oh!

mergify Bot commented Sep 23, 2026 •

edited

Loading

Uh oh!

cursor Bot commented Sep 24, 2026

Uh oh!

mergify Bot commented Sep 24, 2026

Uh oh!

EdbertChan commented Sep 24, 2026

Uh oh!

mergify Bot commented Sep 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

EdbertChan commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Review Claim

Review Lane

Review Unit

Safety Invariant

Slice Rationale

Non-goals

Test Plan

Revert Plan

Uh oh!

EdbertChan commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EdbertChan commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Revision history

Uh oh!

mergify Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EdbertChan commented Sep 23, 2026

Uh oh!

EdbertChan commented Sep 23, 2026

Uh oh!

mergify Bot commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

cursor Bot commented Sep 24, 2026

Bugbot couldn't run - usage limit reached

Uh oh!

mergify Bot commented Sep 24, 2026

🛑 The pull request has been removed from the queue admin-bypass

Uh oh!

EdbertChan commented Sep 24, 2026

Uh oh!

mergify Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

EdbertChan commented Sep 22, 2026 •

edited

Loading

EdbertChan commented Sep 22, 2026 •

edited

Loading

EdbertChan commented Sep 22, 2026 •

edited

Loading

mergify Bot commented Sep 23, 2026 •

edited

Loading

mergify Bot commented Sep 23, 2026 •

edited

Loading

🛑 The pull request has been removed from the queue `admin-bypass`

mergify Bot commented Sep 24, 2026 •

edited

Loading