admin-bypass-repair-bot-thread-pr-840-ea7d365

[EdbertChan]

Summary

A local checker can compare pull request description text with the repository's own rules before an assistant publishes it.

Some repositories keep their rule runner in more than one common location.

This slice treats the repository root as the boundary and searches the supported rule-runner locations.

When no runner exists, publishing advice says unchecked instead of staying quiet.

Accepted descriptions that skip one noisy subcheck still clear the outstanding stack reminder.

Review Claim

Approve that pull request description writes use the matching repository's validator, or receive an explicit unchecked warning.

Review Lane

behavior

Review Unit

engine-runtime

Safety Invariant

The checker still exits zero for every advisory path; this slice only changes which message is shown and whether the stack reminder remains pending.

Assumption: non-interactive request; no separate safety confirmation.

Slice Rationale

This keeps the detector, hook entrypoint, documentation, and focused tests together because they describe one publishing-advice behavior.

Non-goals

• No blocking behavior is added.
• No pull request body rules are reimplemented in the hook.
• No user interface behavior changes.

Architecture

Before

The advisory path only treated repositories with one publishing helper as in scope, and stack publication reminders named one validator path.

After

The advisory path first finds the git repository root, then chooses the first validator path that exists. If no validator exists, publishing commands get an unchecked warning and stack publication does not arm reminder state.

Test Plan

Test Plan

• python3 scripts/ci/check_hook_test_coverage.py engine/hooks/pr-schema-gate - passed with check_hook_test_coverage: OK (1 hook(s) checked).
• python3 scripts/ci/check_no_new_comments.py --base main - passed with ok no new comments.
• CATSTACK_LLM_JUDGE_RUNNERS='[["codex", ["codex", "exec", "--skip-git-repo-check", "--sandbox", "read-only", "-c", "notify=[]", "{prompt}"]]]' PATH="$HOME/.local/bin:$PATH" python3 engine/skills/make-pr/scripts/preflight.py --base origin/main --body-file .pr-body-draft.md - passed with ok preflight passed.
• node scripts/pr/validate-pr-body-local.mjs --body-file .pr-body-draft.md --base main - passed with PR body validation passed.
• Workflow safe-push guard for PR PR body gate (1) the PR-description guard hook runs in catstack #840.
• Workflow review-thread resolver for PRRT_kwDOT3uYWs6lQWRD.
• python3 -m unittest discover -s engine/hooks/pr-schema-gate/tests -v - run locally; failed in test_codex_nested_workdir_can_select_repo_with_tool and test_never_exits_nonzero_for_any_pr_write_in_scope.

Revert Plan

Revert Plan

• Safe to revert? Yes.
• Revert command: git revert 6315464.
• Post-revert steps: rerun the hook coverage check and the no-new-comments check.
• Data migration? No.

---

Note

Medium Risk
Changes which repos get PR-style advisories and when stack follow-up state arms, affecting agent guidance on publishing flows; the hook still never blocks commands.

Overview
pr-schema-gate no longer keys scope on scripts/create-pr.mjs. It walks to the git root (including worktrees with a .git file), picks the first existing validator (scripts/validate-pr-body.mjs or catstack’s engine/skills/draft-pr/scripts/validate-pr-body.mjs), and runs that on file-backed PR writes. Advisory text names the validator path that was used or sought.

Git repos without either validator now get an explicit unchecked warning on PR-publishing commands (gh pr create/edit, gh api body writes, mergify stack push) instead of staying silent; mergify stack push no longer arms the stack follow-up reminder when no validator exists. Directories outside any git repo remain silent; unparseable shell in a repo with no validator stays silent.

Validator exit-0 handling is tightened: a real pass requires PR body validation passed. in the full output, so catstack’s “Summary reading grade unchecked” on stderr no longer flips an accepted body to unchecked or leaves a stale stack reminder. Vacuous exit-0 (UNCHECKED/SKIPPED/not-installed) without that verdict still reports unchecked.

Tests and README document the new scope, catstack-shaped repos, and no-validator behavior. Two CI helpers resolve script paths with os.path.realpath instead of abspath.

^{Reviewed by Cursor Bugbot for commit 6315464. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 6315464. Configure here.}

[cursor]

Stub validator flakes in-scope write tests

Medium Severity

_repo_with_tool now writes a validate-pr-body.mjs stub that exits 0 with no output. check_body_file treats that silent pass as clean, so gh pr edit --body-file /tmp/body.md emits nothing when the file already exists. test_never_exits_nonzero_for_any_pr_write_in_scope and test_codex_nested_workdir_can_select_repo_with_tool then fail because they require an advisory line.

Additional Locations (2)

• engine/hooks/pr-schema-gate/tests/test_hooks.py#L228-L234
• engine/hooks/pr-schema-gate/tests/test_hooks.py#L256-L262

 

^{Reviewed by Cursor Bugbot for commit 6315464. Configure here.}

[mergify]

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.