Repository navigation
diu: one negative per sentence, rewritten as the positive action - #998
Conversation
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Change-Id: Ib4246a96f735602edb0f105dea7adba11114e995
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Change-Id: I5b1152c2f0336b3149ee7290b71afdae13d88eb3
|
This pull request is part of a Mergify stack:
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_58d91cae-27b8-45f3-8b39-6abab7196c50) |
|
Queued — the merge queue status continues in this comment ↓. |
|
Mergify repair stopped: required check failed: validate. The retry cap was reached for current head 01693ce. |
Change-Id: I2b1b949b5eeb2e365a6ee8aff47e2c039bf7c9a6
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_32b4a7da-03e5-41d6-a011-6b7f0b92ef0f) |
|
@Mergifyio queue |
Merge Queue Status
This pull request spent 19 minutes 28 seconds in the queue, including 18 minutes running CI. Required conditions to merge
|
Summary
The always-on writing rule now bans stacked negatives. "No longer queues a check it can never deliver" hides what happens behind two negatives.
The rule says one negative per sentence, rewritten as the positive action: "skips the check once the helper stops." It bites hardest in pull request titles and summaries.
Review Claim
Replies, titles, and summaries carry at most one negative per sentence; stacked "no longer / never" chains are rewritten as the positive action before sending.
Review Lane
behavior
Review Unit
product-skill
Safety Invariant
This slice changes only markdown rule text and a scenario fixture inside one skill, plus a unit test that pins the rule's presence. No hook, script, or gate executes the new sentences; the installed checkers (trigger mechanism, test coverage, three-harness, ecosystem boundaries) all pass against the edited text as it stands.
Slice Rationale
One skill, one new shape rule plus its pre-send check line and a scenario fixture — a single writing-rule change, so it ships alone rather than riding on an unrelated skill edit.
Non-goals
Test Plan
Test Plan
python3 scripts/ci/check_skill_trigger_mechanism.py→ok skill trigger mechanismpython3 scripts/ci/check_skill_test_coverage.py→ok skill test coveragepython3 scripts/ci/check_skills_three_harnesses.py→ok skills three-harness checkpython3 scripts/ci/check_ecosystem_boundaries.py→ok ecosystem boundariespython3 scripts/ci/check_skill_trigger_policy.py→ok skill trigger policypython3 scripts/ci/check_no_dated_provenance.py→ok no dated provenancepython3 -m unittest product.skills.diu.tests.test_stacked_negatives_rule -v→Ran 5 tests/OKpython3 engine/skills/make-pr/scripts/preflight.py --base origin/main --body-file /tmp/diu-pr-body.md→ok preflight passedRevert Plan
Revert Plan
git revert <sha>Note
Low Risk
Markdown-only skill guidance and unittest assertions; nothing executes the new wording at runtime.
Overview
The diu always-on shape rules now require one negative per sentence, rewriting stacked chains like "no longer … never" into the positive action (especially for PR titles and summaries).
SKILL.md updates the front-matter description, adds Part 2 rule #9 with an example, and extends the pre-send checklist with item #6 for multi-negative sentences. A
shape_example.mdscenario fixture documents a bad PR title and the preferred rewrite.test_stacked_negatives_rule.pypins that the rule, positive-action wording, pre-send check, and fixture are present, and that the skill does not instruct retired escape-hatch markers.Reviewed by Cursor Bugbot for commit c85151e. Bugbot is set up for automated code reviews on this repo. Configure here.