Repository navigation
feat(epic-tutorials-ingestor): new heptraining ingestor and tests - #1383
Open
kennethrioja wants to merge 1 commit into
Open
kennethrioja wants to merge 1 commit into
kennethrioja wants to merge 1 commit into
Conversation
| response = open_url(url, raise: true) | ||
| return unless response | ||
|
|
||
| process_frontmatter(response.read) |
Contributor
Author
There was a problem hiding this comment.
Ignore, I will use the source raw file which is not an html, but a md.
Comment on lines
+67
to
+70
| ingestor = if github_url?(url) | ||
| Ingestors::GithubIngestor.new | ||
| elsif indico_url?(url) | ||
| Ingestors::IndicoIngestor.new |
Contributor
Author
There was a problem hiding this comment.
I know, the ingestor will need to wait a day more to ingest more GH resources. I'll keep it like that for now and accept the constraints.
Contributor
Author
|
@fbacall I addressed Copilot reviews (which were not useful here :( ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Heptraining::Ingestorapp/models/source_filter.rb(last time modified by @eilmiv), I got a/code/app/models/source_filter.rb:22: warning: already initialized constant FILTER_DEFINITIONS ... /code/app/models/source_filter.rb:22: warning: previous definition of FILTER_DEFINITIONS was hereand the suggested fix was to include it in theSourceFilterclass, it didn't break tests afaik.Motivation and context
For HEPTraining to be able to scrape trainings from: https://eic.github.io/documentation/tutorials.html
Comments
It is useful to call other ingestors from one ingestor. I hope that one day we create a 'super ingestor' that reads the URL (which is almost always a prerequisite in the ingestors) and sends the job to the relevant ingestor. That would help admins to not choose the wrong ingestor among the 40+ current ingestors.
Checklist