Fix review findings in recipe scrapers - #1
Merged
Merged
Conversation
- Block SSRF in web-reader with a private-host guard and opt-out env var - Correct allenai tools_url docs/example to the /mcp base URL - Send NVIDIA Authorization header on GET /models too - Coerce numeric params via coerce_int/coerce_float in brave-search, wikipedia, x, and openstreetmap - Raise InvalidParamsError for malformed numeric params in nvidia - Keep DeepL stability loop under the default scrape timeout - Kill the bird subprocess on timeout in the x scraper
Endogen
force-pushed
the
review/fix-bugs-1-10
branch
from
September 21, 2026 22:52
e4ab8d0 to
f79ac5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to Endogen/web2api#1.
Changes
WEB2API_WEBREADER_ALLOW_PRIVATEopt-out.tools_urldocs/example to the/mcpbase URL (was pointing at non-existent/tools).Authorizationheader onGET /modelstoo.coerce_int/coerce_float(surfacesINVALID_PARAMSinstead ofSCRAPE_FAILED).InvalidParamsErrorfor malformed numeric params.SCRAPE_TIMEOUT.birdsubprocess on timeout.Tests
web2apifull suite (144 passed) exercises thehackernewsrecipe live against these recipes.