Repository navigation
MOB-387 host-set plist keys exempt from plugin collisions; MOB-392 build dep-shipped Rust static NIFs - #123
Merged
Merged
Conversation
…sets the key The host's ios/Info.plist value always wins (PlistBuddy Add never overrides), so cross_validate/2 exempts plist keys the host sets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nary plists Array values are merged into the host's array (plugin-to-plugin is last-wins), so they still conflict. Commented-out keys no longer count as host-set. Pin the raise_on_cross_plugin_conflicts! wiring to the cwd's ios/Info.plist. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s the conflict Regex scanning counted <key> markup inside CDATA as host keys; reuse IosLayoutPlist's structural parse (new top_level_keys/1). Exempt a key only when no plugin declares it as an array, so mixed array/scalar collisions still raise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
classify_project_nif/2 also finds deps/*/native/<name>/Cargo.toml, and the built archive path is derived from the manifest's dir. mob_rapier's lab_physics was never built, so Operator crashed at launch with 'cannot locate symbol lab_physics_nif_init'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GenericJam
force-pushed
the
mob-plist-shared-keys
branch
from
October 4, 2026 22:05
7133dd7 to
a6da4d9
Compare
GenericJam
changed the title
The deps/* glob missed path deps and custom MIX_DEPS_PATH. Two deps shipping the same crate name now raises instead of picking one. The archive path is one tested helper (rust_nif_archive/3). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…o _build The dependency search runs only when the project has no C/Rust/Zig source for the NIF and skips activated plugins. No blanket rescue around deps_paths. cargo --target-dir puts every Rust NIF archive under _build/<env>/mob_rust_nifs/<name> (read-only deps, workspaces, CARGO_TARGET_DIR). mob.doctor checks Rust targets for dep crates. The default deps_paths lookup is pinned with a path-dep fixture project. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MobDev.Plugin.activated() verifies every plugin manifest (~120 ms in Operator), and it ran once per NIF entry per ABI. nif_dep_dirs/0 does it once and skips the dep search for plugin-contributed entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…gin skip The path-dep fixture test now covers the production lookup, and the plugin skip is a pure nif_dep_dirs/2 with its own test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Review: Codex rounds 1–3 (DO NOT MERGE → fixed); Codex rate-limited until 8:45 PM, so rounds 4–7 by a reviewer subagent (claude -p, read-only). Final: reviewer subagent (Codex rate-limited until 8:45 PM): MERGE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MOB-387: mob_bluetooth + mob_midi both declare NSBluetoothAlwaysUsageDescription → 'activated plugins conflict'. Host ios/Info.plist value wins (PlistBuddy Add), so scalar keys the host sets are exempt (
cross_validate/2:host_plist_keys;host_plist_keys/1parses via xmerl / plutil for binary). Keys any plugin declares as an array still conflict.MOB-392: a :static_nifs entry with no host C/Rust/Zig source (not plugin-contributed) is looked up in every dep from
Mix.Project.deps_paths/0(native/<name>/Cargo.toml; ambiguity raises). Rust NIFs build withcargo --target-dir _build/<env>/mob_rust_nifs/<name>. mob.doctor checks rust targets for such crates. (mob_rapier lab_physics was never built → 'cannot locate symbol lab_physics_nif_init'.)