Repository navigation
MOB-404: mob.release builds native code from the current plugin set - #125
Merged
Merged
Conversation
mix mob.release --android never rebuilt the native library; Gradle imported the jniLibs/<abi>/lib<app>.so the last mix mob.deploy --native left, so a release after adding a native plugin shipped a stale .so and crashed at launch (Operator 1.0.0, mob_sensors: UnsatisfiedLinkError nativeRegister). NativeBuild.build_android_native/2 is the pre-Gradle half of the deploy's Android build (OTP per ABI, jniLibs helpers, zig lib<app>.so with plugin JNI/NIFs, plugin manifest/gradle/kotlin/res/fonts merges), needing no device. The deploy and ReleaseAndroid.build_aab both run it; the release builds every abiFilters ABI and refuses one it can't build. Without zig a leftover lib<app>.so is removed so CMake compiles from source. NativeBuild.prepare_plugin_build_state!/0 (runtime manifest, driver tables, migrations, images, warnings) runs in build_all and both release pipelines; the iOS release linked a stale checked-in driver_tab_ios.c. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r platform checks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Proof (scratch app from local mob_new 0.6.7 master
and Review: reviewer subagent (Codex rate-limited until 2026-10-09 21:14): MERGE on 47a61ea (round 1 should-fix multi-line abiFilters + 2 nits, round 2 nit, all fixed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MOB-404. See CHANGELOG [Unreleased]. Proof and review verdict to follow in comments.