Repository navigation
CI: Do not let vcpkg copy its DLLs next to the Windows test build - #9253
Merged
Merged
Conversation
The vcpkg toolchain runs "vcpkg z-applocal" after each add_library(), which copies hdf5, netcdf, libcurl, z, proj, etc. into build/src and build/src/plugins. GMT loads every DLL found in the plugin directory, so the Windows test job ran with 9 shared library entries and hit the uninitialized-entries bug in gmtapi_init_sharedlibs, and proj_9.dll in build/src also hid the vcpkg share/proj lookup. The dependencies are already found through PATH (ci/install-dependencies-windows.sh), so turn the applocal copy off in tests.yml. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ows too Same change as in tests.yml, so that the three Windows builds are configured alike. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Member
Author
|
Result of the Windows job (https://github.com/GenericMappingTools/gmt/actions/runs/37935561631):
I just pushed a second commit that adds the same flag to I think this can be approved. |
joa-quim
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix the "Failure while closing GMT z shared library" error in the Windows tests.
Claude's:
It works if the error "Failure while closing GMT z shared library" no longer shows up in the log of the Windows job. This does not replace #9251: the uninitialized entries in
gmtapi_init_sharedlibsare still a bug for anyone with 9 or more libraries.build.ymlanddocs.ymlare left as they are.Reviewed with Claude Opus 5.5 (read-only review of the diff). Written with Claude Sonnet 5.5.