Skip to content

Bump to setuptools>=80 and setuptools-scm>=9.2 #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 2 commits into from
Sep 22, 2026
Merged

Bump to setuptools>=80 and setuptools-scm>=9.2 #4910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e3bf70
Bump to setuptools>=80 and setuptools-scm>=9.2
seisman Sep 22, 2026
36c0492
Remove the 'simple' extra
seisman Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["setuptools>=77", "setuptools_scm[toml]>=6.2"]

@seisman seisman Sep 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools-scm[toml] is changed to setuptools-scm[simple].

toml is no longer needed because setuptools-scm started to use the built-in tomllib library since 2022 (pypa/setuptools-scm#740)

@weiji14 weiji14 Sep 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setuptools-scm[toml] is changed to setuptools-scm[simple].

I don't think we're supposed use simple since we're using a custom version scheme in [tool.setuptools_scm]? At least that's what I'm inferring from the docs at https://setuptools-scm.readthedocs.io/v9.2.2/usage/#simplified-activation-new:

image

So maybe remove the [simple]?

@seisman seisman Sep 22, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed [simple] and it still works.

From what I understand, [simple] is meant for use cases with minimal configuration (e.g.,, no [tool.setuptools_scm] section).

See the "Legacy simplified activation (removed in 9.2.0)" box at https://setuptools-scm.readthedocs.io/latest/usage/#using-setuppy-to-pass-code

requires = ["setuptools>=80", "setuptools-scm>=9.2"]
build-backend = "setuptools.build_meta"

[project]
Expand Down
Loading