Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
calcQ1andcalcQ2divide their sums by one fewer epsilon residual than they receive. This inflates Q1, Q2, and cR. It also makes one-residual inputs divide by zero. Divide by the residual count so the functions calculate the absolute mean and the mean square defined by the diagnostics.Fixes #314.
Scope
calcQ1andcalcQ2useepsilon.shape[0].Blast Radius
This changes Q1, Q2, and cR diagnostics. It does not change epsilon residuals or kriging predictions. A controlled variogram comparison changed which Q2 value was closer to the documented target of 1, but no changed published conclusion was established. This correction has not received independent human scientific review.
Verification
.venv/bin/python -m pytest -q tests/test_core.pypassed all 53 tests.OrdinaryKriging(..., enable_statistics=True)reproducer changed reported Q2 values from0.875and1.375to their definition-level values0.7and1.1.2.0instead of1.0and one-residual Q1infinstead of0.5; it passed after the fix.