Conversation
Surface and model self-intersection checks give the AABB a const test and use the returned pairs. The has-intersection checks no longer stop at the first hit: the full search now runs in parallel. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Cpp-Linter Report
|
BotellaA
approved these changes
Sep 26, 2026
BotellaA
left a comment
BotellaA
left a comment
Member
There was a problem hiding this comment.
Maybe remove all false usage like mesh_has_self_intersections()? It may simplify the API?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the self-intersection checks to the new
AABBTree::compute_self_element_bbox_intersectionscontract from Geode-solutions/OpenGeode#1335: aconst, thread-safe test is passed in, and the kept pairs come back. Depends on OpenGeode#1335, which uses the same branch name so CI picks that build up.Changes
SurfaceMeshIntersections:PolygonPolygonIntersectionbecomes aconsttest. Its result vector, mutex andstop_at_first_intersectionflag are removed.ModelMeshesIntersections:constself_intersect()method, passed through a smallSelfIntersectionTestfunctor. It has to be a functor because-Werror=subobject-linkagerejects a lambda that captures an anonymous-namespace type. Their existingoperator()stays forcompute_other_element_bbox_intersections, which keeps the old contract.ComponentOverlapbecomes a predicate that always returnstrue.Behaviour
mesh_has_self_intersections()and the self part ofmodel_has_intersecting_surfaces()no longer stop at the first hit; the full search runs in parallel. On a valid mesh the work is the same as before.Results
nexttest-section, 20 threadstest-section, 2 cores23/23 tests pass. Across 20 threads (two runs), 1 thread and 2 cores, every self-intersection call returned identical results.
🤖 Generated with Claude Code