Repository navigation
Rework how the sample apps are published to Firebase App Distribution #6711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andremion
merged 7 commits into
develop
from
andrerego/and-1546-port-firebase-distribution-improvements
Sep 22, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
24b7275
Publish real release notes with the sample app builds
andremion b3da6d9
Delete the v7 app distribution workflow
andremion b71f48c
Show the SDK version and the commit in the sample app version name
andremion 5c4249f
Take the sample app version from CI instead of the git versioner
andremion 047958c
Distribute the samples from the stream-android-32afb project
andremion 49867b9
Upload the compose sample APK from the path it is built to
andremion 423b4ed
Merge branch 'develop' into andrerego/and-1546-port-firebase-distribu…
andremion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,12 @@ | ||
| static Boolean gitIsAvailable() { | ||
| try { | ||
| "git --version".execute() | ||
| return true | ||
| } catch (Throwable ignored) { | ||
| return false | ||
| } | ||
| } | ||
| def isCI = System.getenv('CI') | ||
| ext["sampleAppVersionCode"] = 1 | ||
| ext["sampleAppVersionName"] = version | ||
| if (isCI && gitIsAvailable()) { | ||
| gitVersioner { | ||
| def branches = ['develop', 'main', 'release'] | ||
| baseBranch branchName in branches ? branchName : branches[0] | ||
| yearFactor 100 | ||
| formatter = { gitVersioner -> | ||
| "1.${gitVersioner.versionCode}.${gitVersioner.featureBranchCommitCount}.${gitVersioner.currentSha1Short}" | ||
| } | ||
| } | ||
| // CI passes these so that every published sample build is a distinct, newer release. | ||
| // | ||
| // The version code is minutes since a fixed epoch rather than a commit count. The same | ||
| // package is published from both develop and main, their commit counts diverge, and Android | ||
| // rejects an install whose version code went backwards. | ||
| // | ||
| // Without the properties the samples keep the fixed values they had before. | ||
| def sdkVersion = version.toString() | ||
| def buildSha = findProperty("sampleAppBuildSha") | ||
|
|
||
| ext["sampleAppVersionCode"] = gitVersioner.versionCode | ||
| ext["sampleAppVersionName"] = gitVersioner.versionName | ||
| } | ||
| ext["sampleAppVersionCode"] = (findProperty("sampleAppVersionCode") ?: "1") as Integer | ||
|
gpunto marked this conversation as resolved.
|
||
| ext["sampleAppVersionName"] = buildSha ? "$sdkVersion-$buildSha".toString() : sdkVersion | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.