Repository navigation
Migrate the replies, pinned messages and send reaction responses to the generated responses - #6774
Conversation
…he generated models
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
SDK Size Comparison 📏
|
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (8)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe pinned-message, reply, and reaction endpoints now use specialized response models. The models include endpoint-specific fields. API fixtures and parsing tests use and validate the new response types. ChangesEndpoint-specific response models
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Suggested reviewers: Merge Risk: ⚪ Minimal · up to No merge-blocking issue is identified; the change is ready for normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to Requests, authentication markers and reaction-state ownership remain unchanged. The remaining risk is response compatibility: missing newly required fields could make a committed reaction appear to fail. No introduced security vulnerability was established. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the message stream Comment |
|
🚀 Available in v7.14.0 |



Goal
Parse the replies, pinned messages and send reaction responses with the generated response models.
Part of AND-1291
Implementation
GetRepliesResponse, pinned messages returnsGetPinnedMessagesResponseand send reaction returnsSendReactionResponse.MessagesResponseandReactionResponseenvelopes. The messages and reactions inside were already generated models, so call sites don't change.duration, and the send reaction response also requiresmessage. The backend always sends both.Testing
MessageListResponseParsingTestcovers each response, a missingdurationand a send reaction response without its message.MoshiChatApiTestrows cover the new response types.On a device: loaded replies through all four variants, loaded pinned messages and sent a reaction. Message order, pinned state, reaction type, score and user, and custom data round-trips all matched.
🤖 Generated with Claude Code
Summary by CodeRabbit