Conversation
…d refactor AppLogsWriter Change-Id: I9757740970000000000000000000000000000002
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines the changes from #523 and #526 along with internal code review and testing improvements:
Summary of Changes
EE10/EE11):--enable_virtual_threads=true) when running on Java 21+, while still allowing opt-out via-Dappengine.use.virtualthreads=falseor--enable_virtual_threads=false.maxCarrierThreads = 4cap onjdk.virtualThreadScheduler.maxPoolSizeso the JVM defaults toavailableProcessors(), while still respecting explicit user configuration (-Djdk.virtualThreadScheduler.maxPoolSizeorJAVA_TOOL_OPTIONS).JdkHttpApiHostClient:JdkHttpApiHostClientbacked byjava.net.http.HttpClientas the defaultAPIHostClientInterfaceimplementation (-Dappengine.api.http.client.use.jdk=trueby default, with fallback to JettyHttpApiHostClientvia-Dappengine.api.http.client.use.jdk=false).HttpRequest.Builder.timeout(...), handles response stream disconnection and cancellation on timeout/interrupt, and bounds defaultmaxConcurrentRequeststo100.AppLogsWriter(runtime-shared):synchronizedblocks aroundApiProxy.flushLogs()with aReentrantLock(flushLock) and a thread-safeConcurrentLinkedDeque+AtomicLongbuffer byte counter so virtual threads do not pin carrier threads during blocking log flushes.beginTransaction()Retry Fix for Concurrency:BaseAsyncDatastoreServiceImpl.beginTransaction()when the local Datastore emulator returns an empty transaction handle under high virtual-thread concurrency.