Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track GHCR downloads over time #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Track GHCR downloads over time #142
Changes from all commits
129747f4a7c7acFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documented response schema for this package-versions endpoint does not contain
download_count; container versions expose fields such asid,name, timestamps, andmetadata. Consequently,// 0silently converts the missing field to zero for every version, and the workflow records a total of zero rather than actual GHCR downloads. Use an API field that exposes package download statistics, and avoid defaulting a missing metric to a valid count.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the initial run, both generated files are untracked because neither is included in this commit.
git diff --quietcompares the working tree with the index and does not report untracked files, as reflected in thegit diffdocumentation, so this condition succeeds and exits beforegit add. Every subsequent run starts from the same checkout and repeats this behavior, meaning the CSV and SVG are never committed; stage the paths before checking the cached diff, or explicitly account for untracked files.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.