Clipboard: Cross-application copy-paste support by VimYoung · Pull Request #4499 · GraphiteEditor/Graphite

VimYoung · 2026-09-03T11:23:11Z

Description

This PR aims to resolve #2373. Solution's approach has been thoroughly discussed in discord's development channel. The PR will fix this issue by introducing copy of both text and svg+xml mime types when copying a selection to the clipboard. Essentially making it possible for other apps to take the svg representation while graphite picks up the internal json representation for copy pasting.

Notes

As mentioned by hypercube, image/svg+xml is not supported by firefox and safari Stable so that is handled.
The intersecting by desktop still doesn't copy the svg and simply ignores it.

Following example showcase the same copy paste not working across apps (krita and inkscape shown as the other apps) in current build vs it working in this branch while still being compatible across graphite tabs.

Before(Only across graphite tabs, not across apps):

editor_before.mp4

After(Across tabs and other apps):

editor_after.mp4

cubic-dev-ai

1 issue found across 8 files

Confidence score: 3/5

In editor/src/node_graph_executor/runtime.rs, selections containing an artboard currently discard the List<Artboard> monitor output and emit an empty SVG, so rendered previews or exports can lose the artboard’s content, position, dimensions, and clipping; render artboard outputs as SVG while preserving those properties.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/node_graph_executor/runtime.rs">

<violation number="1" location="editor/src/node_graph_executor/runtime.rs:351">
P1: When the selection contains an artboard, this branch ignores its `List<Artboard>` monitor output and sends an empty SVG. Render artboard outputs as SVG too, preserving their location, dimensions, and clipping.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-09-06T10:27:01Z

 					return texture;
 				}
+				GraphRuntimeRequest::CopySvgTextClipboard(text_string_clipboard, selected_node_ids) => {
+					let mut combined_graphics = List::<Graphic>::new();


P1: When the selection contains an artboard, this branch ignores its List<Artboard> monitor output and sends an empty SVG. Render artboard outputs as SVG too, preserving their location, dimensions, and clipping.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At editor/src/node_graph_executor/runtime.rs, line 351: <comment>When the selection contains an artboard, this branch ignores its `List<Artboard>` monitor output and sends an empty SVG. Render artboard outputs as SVG too, preserving their location, dimensions, and clipping.</comment> <file context> @@ -340,6 +347,59 @@ impl NodeRuntime { return texture; } + GraphRuntimeRequest::CopySvgTextClipboard(text_string_clipboard, selected_node_ids) => { + let mut combined_graphics = List::<Graphic>::new(); + + for monitor_node_path in &self.monitor_nodes { </file context>

I don't think one can copy the artboard as is, even if they copy every content in the artboard, the copying type would still be graphic (of all selected nodes/layers) ig.

0HyperCube

Works well; thanks for your work so far.

timon-schelling · 2026-09-07T05:59:03Z

I would like to wait with this until winit update is merged. And we might want to make this API lazy.

cubic-dev-ai

1 issue found across 11 files (changes from recent commits).

Confidence score: 3/5

In editor/src/node_graph_executor/runtime.rs, coalescing a copy request with graph evaluation can inspect monitor nodes before execution refreshes them, producing stale or empty SVG in the clipboard; ensure the pending execution completes before monitor introspection.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/node_graph_executor/runtime.rs">

<violation number="1" location="editor/src/node_graph_executor/runtime.rs:203">
P2: When a copy request and a graph evaluation are coalesced in one runtime pass, this line introspects monitor nodes before the pending execution refreshes them, so the clipboard can contain stale or empty SVG. Ensure the copy path reads output from the relevant completed execution, and avoid relying only on request reordering because the execution branch currently returns before later requests.</violation>
</file>

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

cubic-dev-ai · 2026-09-07T13:15:48Z

 		}

-		let requests = [preferences, graph, eyedropper, execution].into_iter().flatten();
+		let requests = [preferences, graph, eyedropper, svg_clipboard, execution].into_iter().flatten();


P2: When a copy request and a graph evaluation are coalesced in one runtime pass, this line introspects monitor nodes before the pending execution refreshes them, so the clipboard can contain stale or empty SVG. Ensure the copy path reads output from the relevant completed execution, and avoid relying only on request reordering because the execution branch currently returns before later requests.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At editor/src/node_graph_executor/runtime.rs, line 203: <comment>When a copy request and a graph evaluation are coalesced in one runtime pass, this line introspects monitor nodes before the pending execution refreshes them, so the clipboard can contain stale or empty SVG. Ensure the copy path reads output from the relevant completed execution, and avoid relying only on request reordering because the execution branch currently returns before later requests.</comment> <file context> @@ -200,7 +200,7 @@ impl NodeRuntime { } - let requests = [preferences, graph, eyedropper, execution, svg_clipboard].into_iter().flatten(); + let requests = [preferences, graph, eyedropper, svg_clipboard, execution].into_iter().flatten(); for request in requests { </file context>

This is technically true however it probably isn't very relevant since the user would be copying an SVG that is not yet rendered into the viewport.

You could fix this by having a result variable instead of an early return:

let mut result = None; for request in requests { match request { // ... GraphRuntimeRequest::ExecutionRequest(ExecutionRequest { execution_id, mut render_config, .. }) => { // ... result = Some(texture); } } } result

VimYoung · 2026-09-07T14:56:48Z

Hey @timon-schelling , we can wait for the API to be merged and then do the changes, what do you mean for the API to be lazy here?
Also can you assign the issue to me as this PR is opened and in review?

timon-schelling · 2026-09-07T15:29:49Z

Hey @timon-schelling , we can wait for the API to be merged and then do the changes, what do you mean for the API to be lazy here?

See the top level API definitions in rust-windowing/winit#4658

Both the DnD and Clipboard APIs are lazy in winit, meaning data only needs to be constructed once the other application accepts (based on data type).

I think we should model it in a similar way.
I'm not completely decided on how to model this with messages though.

Also can you assign the issue to me as this PR is opened and in review?

We usually do that when something is merged.

for fixing test

cubic-dev-ai

All reported issues were addressed across 6 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 8 files (changes from recent commits).

_{Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

0HyperCube · 2026-09-08T16:08:53Z

 		}

-		let requests = [preferences, graph, eyedropper, execution].into_iter().flatten();
+		let requests = [preferences, graph, eyedropper, svg_clipboard, execution].into_iter().flatten();


This is technically true however it probably isn't very relevant since the user would be copying an SVG that is not yet rendered into the viewport.

You could fix this by having a result variable instead of an early return:

let mut result = None; for request in requests { match request { // ... GraphRuntimeRequest::ExecutionRequest(ExecutionRequest { execution_id, mut render_config, .. }) => { // ... result = Some(texture); } } } result

Co-authored-by: James Lindsay <78500760+0HyperCube@users.noreply.github.com>

…ditor#4518) * Switch Color struct back to storing unassociated alpha * Address review feedback * Update the Invert node and legacy image migration for straight alpha and add round-trip tests --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>

)

….rs (GraphiteEditor#4524) Move Gradient Map into adjustments.rs and position it by the classic 0.3/0.59/0.11 luma

… hex string color defaults (GraphiteEditor#4525)

…hiteEditor#4528) Remove the 'Threshold' node's luminance calculation dropdown so it always compares the Rec. 601 luma

Fix cargo about install

…election of desaturation methods (GraphiteEditor#4529) * Remove the 'Threshold' node's luminance calculation dropdown so it always compares the Rec. 601 luma * Find the HSL lightness extremes before encoding and drop a stale luminance TODO

…e', and 'Exposure' nodes (GraphiteEditor#4530)

…e properties (GraphiteEditor#4531) * Add a range slider mode to the spectrum widget and slider rows to node properties * Reset the weighted strength slider to the node's default of zero and skip markers off the track when picking up the nearest one

…es panel (GraphiteEditor#4532) * Show a range slider beside bounded numbers in range mode * Fall back to a plain number widget when a range's bounds are reversed or equal

…or supports having a highlighted stop (GraphiteEditor#4533) * Add a selection mode to the spectrum widget so only the gradient editor keeps a highlighted stop * Record the drag mode for every drag and require selection for reordering so a non-selecting widget cannot drag the wrong stop

…the shared spectrum sections (GraphiteEditor#4534)

… a gamma value (GraphiteEditor#4535) * Add per-channel records and a gamma midtones value to the 'Levels' node, with a channel selector in its Properties panel * Migrate the old 'Levels' midtones through its output range and bound a lone midtone marker by the track edges

… fields (GraphiteEditor#4226) Use cargo workspace to remove dublicated version, license and author fields

* Desktop: Upgrade winit and port DnD to the new data transfer API * Desktop: Read and write the clipboard via the winit data transfer API

…eEditor#4536) * Add colorize and six hue ranges to the 'Hue/Saturation' node * Hide the 'Hue/Saturation' range rows while colorize is on, note the +100 saturation rule, and tidy two lints and a tooltip

… work in linear light (GraphiteEditor#4537) * Add a saturation input to the 'Vibrance' node and rework both axes to work in linear light * Refine the sliders * Clarify some comments

…ntrast' classic toggle now shader compatible (GraphiteEditor#4538)

…ith a filter color in XYZ (GraphiteEditor#4539)

… the Luminosity blend's clipping (GraphiteEditor#4540) * Add a 'Use Tint' toggle to the 'Black & White' node and give its tint the Luminosity blend's clipping * Fix the Black & White migration for a wired tint and gray out the tint when unused

Rename the 'SpectrumInput' widget to 'SliderInput'

…erInput (GraphiteEditor#4546) Make the ColorInput's gradient rendering strategy to use that of SliderInput, fixing a flicker in Firefox when editing gradients

…4547)

cubic-dev-ai

All reported issues were addressed across 8 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 119 files (changes from recent commits).

Not reviewed (too large): node-graph/nodes/raster/src/adjustments.rs (~2,305 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

…ate transform

VimYoung · 2026-09-17T12:57:43Z

Hey @0HyperCube, I have done the changes that you proposed after the second review, please take a look if this PR is still relevant (as there were some ongoing discussions on scrapping it it favor of something that would follow winit's new API changes).

0HyperCube · 2026-09-17T13:25:02Z

Hi @VimYoung, thanks for your continued work on this. In my view this is the most viable approach for the moment.

The winit clipboard support with other types was added in #4519 (graphite now uses a winit fork). It should now be possible to implement the desktop support to this PR. See the clipboard example.

VimYoung and others added 8 commits September 3, 2026 16:38

Broken: Basic Skeleton of DataFlow in a request

6d41257

Broken: Added selected nodes data flow across runtime

2581e7d

Fix: Extraction of nodes into svg and sending message

b897e65

Merge branch 'master' into clipboard-svg-fix

b660117

Fix: Removed comments and unused fn

eedb39e

Add: First support of svg compatible copy pasting

32fbb64

Fix: Desktop copy intercept fix and unnecessary edits removal

a3dabc0

Fix: removed package-lock.json

c06bfac

VimYoung marked this pull request as ready for review September 6, 2026 10:12

VimYoung requested a review from timon-schelling as a code owner September 6, 2026 10:12

cubic-dev-ai Bot reviewed Sep 6, 2026

View reviewed changes

0HyperCube reviewed Sep 6, 2026

View reviewed changes

VimYoung added 4 commits September 7, 2026 18:12

Fix: added todo and removed Svg branch from clipboard data type

e96a66e

Fix: applied fix.patch to avoid message discarding

04dcb84

Fix: renamed TriggerClipboardSvgWrite to TriggerClipboardSvgAndJsonWrite

9ef419f

Fix: converted SvgTextCopyClipboard from typle to struct variant

491a7ac

cubic-dev-ai Bot reviewed Sep 7, 2026

View reviewed changes

Fix: Fix trigger name in clipboard.ts

3f07cbc

VimYoung added 3 commits September 7, 2026 21:20

Merge branch 'master' into clipboard-svg-fix

6b351a6

Add: Fix network_interface to include TriggerClipboardSvgAndJsonWrite

be7c143

for fixing test

Fix: merge text clipboard message and svgtext clipboard trigger into one

c54b027

cubic-dev-ai Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread editor/src/messages/clipboard/clipboard_message_handler.rs

Fix: function abstractions in runtime.rs

f85130e

cubic-dev-ai Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread editor/src/node_graph_executor/runtime.rs

Comment thread editor/src/messages/clipboard/clipboard_message_handler.rs

Comment thread node-graph/libraries/core-types/src/transform.rs

0HyperCube reviewed Sep 8, 2026

View reviewed changes

VimYoung and others added 2 commits September 17, 2026 17:05

Apply suggestion from @0HyperCube

72cbd1f

Co-authored-by: James Lindsay <78500760+0HyperCube@users.noreply.github.com>

Keavon and others added 23 commits September 17, 2026 17:08

Rename the 'Hex to Color' node to 'String to Color' (GraphiteEditor#4523

297ed2b

)

Make 'Gradient Map' use gamma-space luma and move it into adjustments…

b2737ac

….rs (GraphiteEditor#4524) Move Gradient Map into adjustments.rs and position it by the classic 0.3/0.59/0.11 luma

Fix defaulted Item parameters dropping their type alias and rejecting…

eb14240

… hex string color defaults (GraphiteEditor#4525)

New node: Color Balance (GraphiteEditor#4527)

bfe8909

Remove the 'Threshold' node's "Luminance Calculation" parameter (Grap…

fbd782e

…hiteEditor#4528) Remove the 'Threshold' node's luminance calculation dropdown so it always compares the Rec. 601 luma

Fix cargo-about install command (GraphiteEditor#4512)

3604120

Fix cargo about install

Improve accuracy of the 'Channel Mixer', 'Selective Color', 'Posteriz…

d57dd31

…e', and 'Exposure' nodes (GraphiteEditor#4530)

Show a range slider beside bounded range-mode numbers in the Properti…

2bf5d33

…es panel (GraphiteEditor#4532) * Show a range slider beside bounded numbers in range mode * Fall back to a plain number widget when a range's bounds are reversed or equal

Add dashed links between spectrum markers and typed marker scales to …

fdd72eb

…the shared spectrum sections (GraphiteEditor#4534)

Use cargo workspace to remove duplicated version, license, and author…

7ae3353

… fields (GraphiteEditor#4226) Use cargo workspace to remove dublicated version, license and author fields

Desktop: Switch to winit clipboard API (GraphiteEditor#4519)

e487666

* Desktop: Upgrade winit and port DnD to the new data transfer API * Desktop: Read and write the clipboard via the winit data transfer API

Add colorize and six hue ranges to the 'Hue/Saturation' node (Graphit…

76a9486

…eEditor#4536) * Add colorize and six hue ranges to the 'Hue/Saturation' node * Hide the 'Hue/Saturation' range rows while colorize is on, note the +100 saturation rule, and tidy two lints and a tooltip

Add a saturation input to the 'Vibrance' node and rework both axes to…

730d09d

… work in linear light (GraphiteEditor#4537) * Add a saturation input to the 'Vibrance' node and rework both axes to work in linear light * Refine the sliders * Clarify some comments

Retire the 'Brightness/Contrast Classic' node with the 'Brightness/Co…

b363f70

…ntrast' classic toggle now shader compatible (GraphiteEditor#4538)

New node: 'Photo Filter' to warm or cool an image by multiplying it w…

dfe1319

…ith a filter color in XYZ (GraphiteEditor#4539)

Rename the SpectrumInput widget to SliderInput (GraphiteEditor#4541)

3be0d8c

Rename the 'SpectrumInput' widget to 'SliderInput'

Make the ColorInput's gradient rendering strategy to use that of Slid…

42d78b9

…erInput (GraphiteEditor#4546) Make the ColorInput's gradient rendering strategy to use that of SliderInput, fixing a flicker in Firefox when editing gradients

Fix several bugs causing warning spam in the console (GraphiteEditor#…

10f5cab

…4547)

cubic-dev-ai Bot reviewed Sep 17, 2026

View reviewed changes

Comment thread editor/src/node_graph_executor.rs

VimYoung requested a review from TrueDoctor as a code owner September 17, 2026 11:39

Merge branch 'master' into clipboard-svg-fix

6dcd240

cubic-dev-ai Bot reviewed Sep 17, 2026

View reviewed changes

Comment thread editor/src/node_graph_executor/runtime.rs

Refac: Extracted run match statements into functions && remove duplic…

8cc582b

…ate transform

Uh oh!

Conversation

VimYoung commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot Sep 6, 2026

Choose a reason for hiding this comment

Uh oh!

VimYoung Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0HyperCube left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

timon-schelling commented Sep 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

0HyperCube Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VimYoung commented Sep 7, 2026

Uh oh!

timon-schelling commented Sep 7, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0HyperCube Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

VimYoung commented Sep 3, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading