Merge har.fyi under docs - #1332
Conversation
62ed224 to
7e256f0
Compare
748b5d9 to
3f42796
Compare
…rchive.org into merge-har-docs Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
|
Visit the preview URL for this PR (updated for commit 1eda9af): https://httparchive--pr1332-merge-har-docs-znie7fha.web.app (expires Wed, 07 Oct 2026 12:30:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 1069cba7974889c25bacf4f0a19ddb6735592729 |
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
…and CodeQL TOCTOU race condition
…color alias notation
|
Looking better and better. It definitely feels like it's all part of one site now with the same menu persistent across all pages. It's not quite one case, but the illusion is there. A few more asks for me:
|
|
@tunetheweb 'docs/docs/' is Starlights artifact. And Starlight doesn't have a feature to define prefix. |
…ation Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
# Conflicts: # package-lock.json # package.json
|
@tunetheweb with unified footer and header now |
tunetheweb
left a comment
There was a problem hiding this comment.
Does the docs Search work for you in the preview? Looks like we might need to add unsafe-eval to our CSP :-(
| align-items: center; | ||
| justify-content: space-between; | ||
| box-sizing: border-box; | ||
| max-width: 1200px; |
There was a problem hiding this comment.
This looks weird when the docs page isn't constrained. The Logo in the header jumps to the right. Maybe we should drop this?
There was a problem hiding this comment.
I adjusted it to the main page, since it's a shared header now.
I understand you expect to see unconstrained on docs/ and centered on the website root?
Let's share the header & footer styling - unconstrained across root and docs?
There was a problem hiding this comment.
Yeah sounds good.
The header looks good now.
I still don't see the footer on the docs page?
There was a problem hiding this comment.
I removed the footer in docs as the header sticks to the top of the screen.
Having both of them just duplicates the links and squeezes the space for content too much.
There was a problem hiding this comment.
Ah OK. In that case I think this looks good to land. I'm just checking with @rviscomi as to how we can redirect har.fyi to this new location.
There was a problem hiding this comment.
OK Rick's confirmed he's good to set up a redirect once this is released, so good to merge this.
…olicy Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Fixed CSP. |
…yout to full width Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>

This PR merges
har.fyicontent directly intohttparchive.orgunder the/docs/path:@astrojs/starlight,starlight-links-validator,starlight-llms-txt)src/content/docs/har.fyito relative/docs/paths