Skip to content

Merge har.fyi under docs - #1332

Merged
max-ostapenko merged 20 commits into
mainfrom
merge-har-docs
Sep 30, 2026
Merged

max-ostapenko merged 20 commits into
mainfrom
merge-har-docs

Conversation

@max-ostapenko

@max-ostapenko max-ostapenko commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

This PR merges har.fyi content directly into httparchive.org under the /docs/ path:

  • Adds Astro Starlight integration (@astrojs/starlight, starlight-links-validator, starlight-llms-txt)
  • Migrates all guides, reference docs (tables, blobs, structs, custom metrics, functions), and assets into src/content/docs/
  • Integrates custom Starlight header matching HTTP Archive branding and search
  • Updates sitemap and timestamp generation to index doc pages
  • Updates site navigation and references pointing to har.fyi to relative /docs/ paths

@tunetheweb tunetheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking much better on desktop but still have the double hamburger menu issues on mobile:

Image

@max-ostapenko
max-ostapenko force-pushed the courageous-galliform branch 2 times, most recently from 62ed224 to 7e256f0 Compare September 20, 2026 14:16
Base automatically changed from courageous-galliform to main September 20, 2026 14:16
Comment thread tools/generate/generate_timestamps.js Fixed
…rchive.org into merge-har-docs

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 1eda9af):

https://httparchive--pr1332-merge-har-docs-znie7fha.web.app

(expires Wed, 07 Oct 2026 12:30:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 1069cba7974889c25bacf4f0a19ddb6735592729

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@tunetheweb

Copy link
Copy Markdown
Member

Looking better and better. It definitely feels like it's all part of one site now with the same menu persistent across all pages. It's not quite one case, but the illusion is there.

A few more asks for me:

  1. Could we have a consistent footer? Currently the Docs pages don't have any footer at all.
  2. I think, given it's a whole micro-site, this deserves it's own top-level menu item in the header rather than being buried under the About menu.
  3. I still don't understand the need for src/content/docs/docs. Can't it all be under src/content/docs/ and avoid that double doc/docs?

@max-ostapenko

Copy link
Copy Markdown
Contributor Author

@tunetheweb 'docs/docs/' is Starlights artifact.
It expects a collection under 'src/content/docs/', but as our website is not just docs, keeping the documentation right under 'docs/' will conflict with the rest of Astro pages.

And Starlight doesn't have a feature to define prefix.

…ation

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
# Conflicts:
#	package-lock.json
#	package.json
@max-ostapenko

Copy link
Copy Markdown
Contributor Author

@tunetheweb with unified footer and header now

@tunetheweb tunetheweb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the docs Search work for you in the preview? Looks like we might need to add unsafe-eval to our CSP :-(

Comment thread src/components/Header.astro Outdated
align-items: center;
justify-content: space-between;
box-sizing: border-box;
max-width: 1200px;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks weird when the docs page isn't constrained. The Logo in the header jumps to the right. Maybe we should drop this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted it to the main page, since it's a shared header now.
I understand you expect to see unconstrained on docs/ and centered on the website root?

Let's share the header & footer styling - unconstrained across root and docs?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sounds good.

The header looks good now.

I still don't see the footer on the docs page?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the footer in docs as the header sticks to the top of the screen.
Having both of them just duplicates the links and squeezes the space for content too much.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK. In that case I think this looks good to land. I'm just checking with @rviscomi as to how we can redirect har.fyi to this new location.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Rick's confirmed he's good to set up a redirect once this is released, so good to merge this.

…olicy

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko

Copy link
Copy Markdown
Contributor Author

Does the docs Search work for you in the preview? Looks like we might need to add unsafe-eval to our CSP :-(

Fixed CSP.

…yout to full width

Signed-off-by: Max Ostapenko <1611259+max-ostapenko@users.noreply.github.com>
@max-ostapenko
max-ostapenko merged commit 96cdfaf into main Sep 30, 2026
11 checks passed
@max-ostapenko
max-ostapenko deleted the merge-har-docs branch September 30, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants