Modernize VAST Tester - #47
Open
aleksUIX wants to merge 25 commits into
Open
Conversation
Restores shared ancestry with IAB upstream while preserving the current committed tester tree.
aleksUIX
changed the title
aleksUIX
marked this pull request as ready for review
June 8, 2026 01:18
0.10.2 predates the CTV Ad Portfolio VAST 2.0 extension path, so the tester reported nothing at all on a tag using <Extension type="ctv_ad_portfolio"> or <CreativeExtension type="tl_qrcode">. 0.11.0 added six rules for the 2.0 container plus the two Format-to-Signal cross-checks, and 0.11.1 closed the NonLinear traversal hole where MediaFile, Mezzanine, InteractiveCreativeFile and Icon went unvalidated under the CTV content model. Catalog goes from 212 to 220 rules. No API change; the build and typecheck are unaffected.
0.11.3 predates the CTV Ad Portfolio extension-container validation added in 0.11.4, so the tester reported nothing for a defective <MediaFile>, <Duration>, <Icon> or <Tracking> inside <Extension type="ctv_ad_portfolio">. 0.11.5 is the element-dispatch refactor, which reports identically. Catalog stays at 220 rules. No API change; build and typecheck unaffected.
Adds VAST-4.4-qrcode-missing-image-url and VAST-3.0-adparameters-xmlencoded-value, and <Duration> is now format-checked under <NonLinear>. Catalog 220 to 222.
The tester now publishes to two independent providers from the same commit. Cloudflare Pages stays the primary and is unchanged: `npm run deploy:pages` still builds with the default base and uploads dist. The new workflow builds the same tree with `--base=/VAST-Tester/` on the command line, so the base path lives only in CI and vite.config.ts keeps producing a root-relative build for Cloudflare. tsconfig.node.json could not typecheck from a clean `npm ci`. It asked for `types: ["node"]`, but @types/node is only an optional peer of vite and is never installed by the committed lockfile; local builds passed only because other tooling happened to pull it in. It also set no target or lib, so it defaulted to ES5 and could not read vite's own declarations. It is now self-contained: ES2022, no ambient types, skipLibCheck on. vite.config.ts uses no Node globals, so nothing is lost.
The masthead link hid the address behind "Send feedback" text and pointed at a stale alias. Show alex@vastlint.org as readable text in the masthead and footer, and add a contextual prompt under the findings table that opens a prefilled mail draft carrying the tag and the reported rule IDs.
Handshake, protocol log, host transport, and simulate now run in the tester so creative QA does not need a custom player.
…nner against a local host clip.
… session before they run one.
…fills the tester column.
The default demo had no Error URL, so SSAI-safe failed, then the findings panel still told people to run validate. Add the beacon and show lens reasons instead.
Give partner QA a pasteable session envelope, and put the extension-container path next to the 4.4 native samples so Advanced TV can click both XML shapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restage of the rewritten tester on current upstream
master. Vite + React UI,vastlint/vastlint-client/vastlint-reactfrom npm (0.13.8), IAB-neutral chrome.Preview: https://iab-vasttester.vastlint.org/
What is included
IABTechLab/VAST-Tester. No analytics, no sample collectionValidation
npm installnpm run build