Repository navigation
Propagate metadata upload failures through setup - #12805
youseihuayu-wonderful wants to merge 3 commits into
Conversation
ErykKul
left a comment
There was a problem hiding this comment.
Thanks for picking this up! The uploader change looks good. The main issue is the early exit: a failed block now skips the rest of setup, including the admin API lockdown, and leaves an instance that can't be re-bootstrapped. The inline comments on setup-all.sh and install.py suggest letting setup finish and exiting non-zero at the end, plus a test for that.
|
@ErykKul Thanks — addressed in 17aa7aa. Setup now retains the metadata failure, finishes remaining configuration and security lockdown, then exits non-zero. Dev stays intentionally insecure; demo completes its lockdown; the installer still runs step 8c; bootstrap preserves env export. Added lockdown/status regressions and stricter curl request checks: 44 examples, 0 failures, 1 existing skip. Live Docker checks confirmed admin/root creation, demo/installer API blocking, and installer exit 0/1. #12467 still stops before Solr and "Done" on HTTP 500. Guide/release note corrected. Installer verification covers its actual packaged post-deployment stage, not full host provisioning. Ready for re-review. |
|
Looks good to me, approved. QA'd with fresh unstable images and this PR's scripts, using a TSV with an invalid displayOrder:
#12467's update-metadata.sh: stops before Solr and "Done" on failure, works normally otherwise |
17aa7aa to
3c36d05
Compare
Closes #12804. Related to #12467.
Problem
The shared metadata uploader ignored HTTP errors: an HTTP 500 could still end with exit 0 and "Done". Bootstrap and the installer also use this script.
Fix
Verification
Guide/release note updated. Successful block uploads are not rolled back. Implementation and verification were AI-assisted.