Repository navigation
Add four passing integration test classes to tests/integration-tests.txt - #12816
Closed
ashmanda-cs wants to merge 1 commit into
Closed
ashmanda-cs wants to merge 1 commit into
ashmanda-cs wants to merge 1 commit into
Conversation
DataCiteIT, SignedUrlAuthMechanismIT, SiteMapIT and StorageSitesIT pass against the CI stack but were never listed, so they never ran.
Contributor
Author
|
Replaced by #12817, which uses a branch named after the issue (12815-add-four-passing-integration-test-classes). Same commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds four integration test classes to
tests/integration-tests.txt:DataCiteIT,SignedUrlAuthMechanismIT,SiteMapITandStorageSitesIT. They pass against the CI stack but were never listed, so they never ran. That's 9 more tests in CI for about 10 seconds.See #12815 for how they were found, and for why
IpGroupsITstays out of the list even though it passes on its own.Which issue(s) this PR closes:
Special notes for your reviewer:
The only change is one line in
tests/integration-tests.txt. The same change was verified in our fork, on top of #12783: run 38064623496 gave 416 integration tests run, 0 failures and 15 skipped in all three jobs (was 407 / 0 / 15).Suggestions on how to test this:
In the integration test results of this PR's checks, confirm that the four classes ran and passed, and that the totals went from 407 to 416 with 0 failures.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No. It only changes which existing tests run in CI.
Additional documentation:
None.