fix(mcp): add search fallback to get_doc and generic-stripped lookup to get_api_reference - #1808
Merged
Merged
Conversation
dkalinovInfra
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
No base build to compare — dkalinov/searchFallback into master |
kdinev
reviewed
Sep 24, 2026
kdinev
left a comment
kdinev
left a comment
Member
There was a problem hiding this comment.
I'll wait to see if there would be any additional changes produced from the copilot review. Looks good to me so far.
…d case-insensitive matching
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Case-insensitive generic requests can incorrectly resolve to the corresponding non-generic API type.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
Resolved since last review (1)
kdinev
approved these changes
Sep 24, 2026
kdinev
left a comment
kdinev
left a comment
Member
There was a problem hiding this comment.
Looks good. The last copilot comment requires a large code change and can be ignored for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves name resolution in the MCP server so agents get the doc/API entry they meant instead of an error.
get_docresolveDoc()with a resolution chain: alias → Angular compact grid prefix (tree-grid-editing→treegrid-editing) →grid-retry → full-text search fallback. Search-fallback hits are prefixed with a "closest match" notice so the caller can tell a substitution from an exact hit.parseDocNamesunderstands both the local ((`name`)) and remote (**name**) search result formats — previously the fallback silently returned not-found in remote mode.sanitizeSearchDocsQuerystrips natural-language stopwords ("how do I …") that made FTS4 implicit-AND queries return nothing.normalizeDocNamecollapses spaces/underscores to hyphens ("date picker"→date-picker).get_api_referencemembervalues (" ",".*","*") are treated as omitted instead of failing with-32602; agents send these when they want the full entry.IgbCombo/igbcomboresolve to the indexedIgbCombo<T>. Exact non-generic names still win (DynamicContentInfovsDynamicContentInfo<T>).Related Issue
N/A — driven by an agent evaluation sweep against the MCP server.
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context
tsc --noEmitclean.get_doccan now serve a "closest match" doc (with a notice) where it previously returnedisError.IgbCombo<T>is defined in bothIgniteUI.BlazorandIgniteUI.Blazor.Lite; the loader keys by name with last-wins, so the Lite entry shadows the full one for every shared name. Worth a separate issue (package-priority rule inApiDocLoader).