Aparna pradhan build issues - #6
Open
AparnaPradhan wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Fix application startup failures: Firebase, Java version, and infrastructure setup
Description:
Summary
forums-firebase.jsonFireBaseMessagingServicewhen Firebase credentials are not presentChanges
Firebase (conditional startup)
FireBaseMessagingConfiguration— added@ConditionalOnResourceso the Firebase bean is only created whenforums-firebase.jsonexists on the classpathFireBaseMessagingServiceImpl— added@ConditionalOnBean(FirebaseMessaging.class)so it is only registered when Firebase is configuredSummary
forums-firebase.jsonFireBaseMessagingServicewhen Firebase credentials are not presentChanges
Firebase (conditional startup)
FireBaseMessagingConfiguration— added@ConditionalOnResourceso the Firebase bean is only created whenforums-firebase.jsonexists on the classpathFireBaseMessagingServiceImpl— added@ConditionalOnBean(FirebaseMessaging.class)so it is only registered when Firebase is configuredFireBaseMessagingServiceNoOpImpl(new) — no-op fallback that satisfies theFireBaseMessagingServicedependency and logs a warning when Firebase is notconfigured
Infrastructure setup
The application requires the following services running before startup:
localhost:5432— start withdocker compose -f src/main/docker/postgresql.yml up -dlocalhost:9080— start withdocker compose -f src/main/docker/keycloak.yml up -dmvn spring-boot:run -Denforcer.skip=trueif using JDK 15+