Repository navigation
feat: write reports below TestPioneer's artifact directory - #120
Merged
Merged
Conversation
TestPioneer starts a runner with TEST_PIONEER_ARTIFACT_DIR set to the directory that run output belongs in. A report asked for under a relative name is now written below it, for every report generator, and the path a generator returns is the path it wrote. Without the variable, and for an absolute name, nothing changes.
|
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 20 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
JE-Chen
marked this pull request as ready for review
October 11, 2026 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With
TEST_PIONEER_ARTIFACT_DIRset, a report asked for under a relative name is written below that directory, and missing folders are created. Without the variable nothing changes.Why
TestPioneer starts every runner with that variable set to the directory the run's output belongs in (TestPioneer PR #32,
docs/artifacts.rst, "Native Support"). A runner that writes its report there needs noartifacts:entry in the workflow and leaves nothing in the working directory. The other half of that contract, a non-zero exit status after a failed action, has been here since PR #118. APITestka has both in its PR #149.How
utils/generate_report/report_path.pyplaces a relative name below the directory. All fifteen report generators use it (JSON, XML, HTML, JUnit, summary, CSV, cost, CycloneDX, SARIF, service map, Excel, PDF, chart, histogram, Allure), and the path a generator returns is the path it wrote.An absolute name is used as given, which is what APITestka's
load runpasses. So are a name that would leave the directory and a directory that cannot be created.Checks
test/test_report_path.py: 22 tests, two of them skipped here for lack ofmatplotlibandreportlab.test/smoke: 1504 passed, 19 skipped.test/test_distributed_health.pywas left out: one of its tests, which starts networked workers, failed on the machine it was run on, and it was not compared with an unchanged checkout.Docs: the three READMEs (Reports),
architecture.md§6,docs/updates/.