BUG: fix absolute() returning -NaN for +NaN on scalar path - #269
Open
vchamarthi wants to merge 3 commits into
Open
BUG: fix absolute() returning -NaN for +NaN on scalar path#269vchamarthi wants to merge 3 commits into
vchamarthi wants to merge 3 commits into
Conversation
vchamarthi
requested review from
antonwolfy,
jharlow-intel,
ndgrigorian,
vlad-perevezentsev and
xaleryb
as code owners
September 11, 2026 15:06
ndgrigorian
previously approved these changes
Sep 11, 2026
ndgrigorian
reviewed
Sep 11, 2026
ndgrigorian
previously approved these changes
Sep 11, 2026
Collaborator
|
@vchamarthi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkl_umath_@TYPE@_absolute's scalar/small-array fallback usesin1 > 0 ? in1 : -in1, which flips the sign of+NaNsince NaNcomparisons are always false. Uses
fabs/fabsfinstead, whichclears the sign bit unconditionally. Same bug numpy fixed upstream
in dc478c58b9 (gh-31433).
How found
Test failures caught it when upgrading to intel numpy 2.5.3