Repository navigation
Require one cluster with BOOTSTRAP_DIR, rename FORBID_RESPIN - #3713
Merged
Merged
Conversation
A testnet set up from BOOTSTRAP_DIR can only back a single cluster instance. Raise an error when CLUSTERS_COUNT is not 1, including when it was derived from the xdist worker count, instead of trying to run multiple instances against the testnet.
The option forbids respinning cluster instances, so name it after the term the cluster management code uses. The old FORBID_RESTART env var is no longer recognized.
mkoura
requested
a lite review from Copilot
and removed request for
saratomaz
September 25, 2026 12:36
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Add tests covering invalid and valid BOOTSTRAP_DIR cluster-count configurations.
Review effort: Lite
Findings: None
What changed in this PR
This PR enforces single-cluster use of BOOTSTRAP_DIR and renames FORBID_RESTART to FORBID_RESPIN.
Changes:
- Validates
CLUSTERS_COUNT=1for bootstrap-directory configurations. - Updates scripts, cluster management, tests, and documentation for
FORBID_RESPIN.
| File | Description |
|---|---|
scripts/setup_test_env.sh |
Uses FORBID_RESPIN. |
runner/run_tests.sh |
Updates runner documentation and exports. |
runner/node_upgrade.sh |
Uses the renamed variable. |
framework_tests/test_cluster_getter.py |
Updates configuration references. |
cardano_node_tests/utils/configuration.py |
Adds single-cluster bootstrap validation. |
cardano_node_tests/cluster_management/cluster_getter.py |
Applies the renamed respin setting. |
agent_docs/tag_testing.md |
Updates tag-testing documentation. |
.source.dev |
Updates development environment setup. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BOOTSTRAP_DIR: a testnet set up fromBOOTSTRAP_DIRcan only back one cluster instance.configuration.pynow raises an error whenCLUSTERS_COUNTis not 1 in that case. This also catches the case whereCLUSTERS_COUNTis unset and falls back to the xdist worker count (e.g. plainpytest -n 4). Previously the framework would try to run several instances against the testnet. Thetestnetsrunner target already exportsCLUSTERS_COUNT=1, so it is not affected.FORBID_RESTARTtoFORBID_RESPIN: the option forbids respinning cluster instances, so it now uses the term the cluster management code uses. Runner scripts,.source.dev, the framework tests, docs and related comments are updated.Breaking change
The old
FORBID_RESTARTenv var is no longer recognized. External CI jobs or local scripts that setFORBID_RESTART=truemust switch toFORBID_RESPIN=true. Otherwise the setting is silently ignored and clusters may get respun.