Fix parseStatements failure propagation and executor cleanup - #2568
Open
minleejae wants to merge 1 commit into
Open
Fix parseStatements failure propagation and executor cleanup#2568minleejae wants to merge 1 commit into
minleejae wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseStatements("SELECT FROM", parser -> parser.withAllowComplexParsing(false)) currently returns null after a parse failure. The same happens when the configured nesting limit prevents the complex retry, including a swallowed timeout exception.
Return each successful parse directly and rethrow the original JSQLParserException when retry is unavailable. Wrap the convenience overload's internally created executor in try/finally so failure also shuts it down. Caller-owned executors remain open; null/empty-input behavior and unsupported-statement recovery are preserved.
Validation: